-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigment-css] Fix keyframes
serialize styles error
#41395
Conversation
Netlify deploy previewhttps://deploy-preview-41395--material-ui.netlify.app/ Bundle size report |
const [, ...callParamsRest] = callParams; | ||
|
||
callParamsRest.flat().forEach((item) => { | ||
if ('kind' in item) { | ||
this.dependencies.push(item); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow the styled
implementation.
args.length > 0 | ||
? [styleObjOrTaggged as Interpolation<{}>, ...args] | ||
: [styleObjOrTaggged as Interpolation<{}>], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is required to prevent ILLEGAL_ESCAPE_SEQUENCE_ERROR
from emotion because serializeStyles
assumes that []
is an expression.
Root cause
Passing empty
args
([]
) to emotion'sserializeStyles
is not allowed.Full error:
The rest of the changes are splitting tests into small cases