[system][core] Standardize index pattern #41574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
package: system
DiegoAndai
changed the title
DiegoAndai
changed the title
Netlify deploy preview@material-ui/core: parsed: -3.46% 😍, gzip: -2.75% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
force-pushed
the
standardize-system-index-pattern
branch
from
e3787c0 to
bbf1791
Compare
DiegoAndai
changed the title
DiegoAndai
force-pushed
the
standardize-system-index-pattern
branch
from
bbf1791 to
e2de1a8
Compare
|
I'm not sure why the |
DiegoAndai
force-pushed
the
standardize-system-index-pattern
branch
from
e2de1a8 to
95f2bc8
Compare
mnajdova
reviewed
Mar 25, 2024
Comment on lines
+1
to
+2
| 'use client' | ||
| export * from './colorManipulator' |
There was a problem hiding this comment.
We are missing semicolons in these files, how did the CI pass? 😕 I created #41636 to address this.
There was a problem hiding this comment.
how did the CI pass?
> @mui/[email protected] prettier /tmp/material-ui
> pretty-quick --ignore-path .eslintignore "--check"
🔍 Finding changed files since git revision null.
🎯 Found 0 changed files.
✅ Everything is awesome!
I believe we're hitting prettier/pretty-quick#127
We should probably add the --branch flag to pretty-quick?
pluvio72
pushed a commit
to pluvio72/material-ui
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #30671
Standardize index pattern in
@mui/systempackage, in which all exports have the build structureThis eases the move into using the
exportsfield. This pattern is followed in all other packages except@mui/icons-material, an exception as we'll move it to ESM only.Breaking changes
Added here: https://deploy-preview-41574--material-ui.netlify.app/system/migration/migration-v5/
@mui/systempackage no longer has CJS in its root, but ESM instead, which was previously inside theesm/build. The CJS code is moved to thenode/build.cssGrid's functionGridPropstype toCssGridProps, asGridPropswas already being used for theGridcomponent.