Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][ListItem] Replace <ListItem button/> with <ListItemButton/> in composition guide #43356

Closed
wants to merge 1 commit into from
Closed

[material-ui][ListItem] Replace <ListItem button/> with <ListItemButton/> in composition guide #43356

wants to merge 1 commit into from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 18, 2024 •
edited
Loading

Since button prop in ListItem is removed, we should remove it's references from docs

@sai6855 sai6855 added docs Improvements or additions to the documentation component: list This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 18, 2024
@sai6855 sai6855 requested a review from ZeeshanTamboli August 18, 2024 08:09
@mui-bot
Copy link

mui-bot commented Aug 18, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 90886f2

ZeeshanTamboli
ZeeshanTamboli reviewed Aug 18, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but I have already handled this in #43266.

@sai6855 sai6855 deleted the list branch August 18, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @ZeeshanTamboli