Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Fix calendar year child div #4344

Closed
wants to merge 2 commits into from
Closed

Conversation

ColadaFF
Copy link

@ColadaFF ColadaFF commented May 25, 2016

Added style to div child of the component to show all the years inside the minDate and maxDate range, it set the div style to inherit the height from its parent div.

fixes mui/mui-x#7495

Added style to div child of the component to show all the years inside the minDate and maxDate range.
@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 25, 2016
@mbrookes mbrookes added Regression and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels May 29, 2016
@mbrookes mbrookes added this to the 0.15.1 Release milestone May 29, 2016
@mbrookes mbrookes added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 29, 2016
@mbrookes
Copy link
Member

@ColadaFF This breaks the vertical centering when a small range of years is set. CAn you take another look?

@ToxicSalt Feel free to chip in, since you also had a PR this issue.

@DylanSimowitz
Copy link

DylanSimowitz commented May 30, 2016

@mbrookes #4381 Finally a css only solution!

Also I'm kind of new to git, is there a way I can work off of someone else's PR?

@mbrookes
Copy link
Member

@ToxicSalt There is - you can pull from and submit a PR to their fork / branch, they then merge it, and the PR here appears as a combine contribution.

However, just the sake of internet brownie points, it's probably not worth it for this PR. It might just be easier to close this, and update the title and description of #4381.

@mbrookes mbrookes mentioned this pull request May 31, 2016
3 tasks
@mbrookes
Copy link
Member

mbrookes commented Jun 8, 2016

Closing in favor of #4381. @ColadaFF thanks for your contribution that is included in that PR@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DatePicker] Year overflow broken
4 participants