Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v6.1.3 #44038

Merged
merged 10 commits into from
Oct 9, 2024
Merged

[release] v6.1.3 #44038

merged 10 commits into from
Oct 9, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Oct 8, 2024

@mnajdova mnajdova added the release We are shipping :D label Oct 8, 2024
@mui-bot
Copy link

mui-bot commented Oct 8, 2024

Netlify deploy preview

https://deploy-preview-44038--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 579e39a

@mnajdova
Copy link
Member Author

mnajdova commented Oct 8, 2024

I am not sure where the changes from pnpm dedupe are coming from, here is the commit: 9fae471. Something is happening with the @mui/material-pigment-css package. The differences are somewhat coming from @toolpad/core, @Janpot do you have an idea what may be causing this?

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Marija Najdova <[email protected]>
@mnajdova mnajdova requested a review from Janpot October 8, 2024 09:47
@Janpot
Copy link
Member

Janpot commented Oct 8, 2024

The differences are somewhat coming from @toolpad/core, @Janpot do you have an idea what may be causing this?

Does it work if you do

pnpm store prune && pnpm dedupe

?

@mnajdova
Copy link
Member Author

mnajdova commented Oct 8, 2024

The step was failing on the CI, check https://app.circleci.com/jobs/github/mui/material-ui/758364.

@Janpot
Copy link
Member

Janpot commented Oct 8, 2024

Does the lock file change when you execute that command? you can commit those changes

@mnajdova
Copy link
Member Author

mnajdova commented Oct 8, 2024

Does the lock file change when you execute that command? you can commit those changes

Yeah it did, and I commited the changes, I was just surprised that there were changes, this is why I tagged you.

@mnajdova mnajdova requested a review from DiegoAndai October 8, 2024 12:35
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2024
@mnajdova mnajdova merged commit c7de2ca into mui:master Oct 9, 2024
18 checks passed

### `@mui/[email protected]`

- &#8203;<!-- 18 -->Change React.ReactElement<any> to React.ReactElement<unknown> (#43402) @sai6855
Copy link
Member

@oliviertassinari oliviertassinari Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those &#8203;<!-- 18 --> feel like noise during the review and when reading the changelog source, I'm proposing we remove them: #44052.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants