-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Add StackBlitz/CodeSandbox buttons to template cards #44253
Conversation
Netlify deploy previewhttps://deploy-preview-44253--material-ui.netlify.app/ Bundle size report |
…buttons-templates
@siriwatknp one last thing, would it be possible to add the template titles to the ToC? |
@@ -68,7 +68,7 @@ export default function AppNavbar() { | |||
Dashboard | |||
</Typography> | |||
</Stack> | |||
<ColorModeIconDropdown /> | |||
<ColorModeIconDropdown data-screenshot="" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I’m not mistaken, it’s for the screenshot script work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I didn't found any other occurrence of data-screenshot=""
, only data-screenshot="toggle-mode"
and data-screenshot="toggle-default-theme"
, that's why I was asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need @siriwatknp to answer this then haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove the data-screenshot
from this button (in mobile) because there are two of them (desktop and mobile) on the page. Playwright was not happy with it.
This PR adds the StackBlitz/CodeSandbox buttons to the templates' cards in the templates page, also adding some visual tweaks to the page layout.
👉 https://deploy-preview-44253--material-ui.netlify.app/material-ui/getting-started/templates/