Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Add StackBlitz/CodeSandbox buttons to template cards #44253

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 29, 2024

This PR adds the StackBlitz/CodeSandbox buttons to the templates' cards in the templates page, also adding some visual tweaks to the page layout.

Current New
image image

👉 https://deploy-preview-44253--material-ui.netlify.app/material-ui/getting-started/templates/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Oct 29, 2024
@zanivan zanivan self-assigned this Oct 29, 2024
@mui-bot
Copy link

mui-bot commented Oct 29, 2024

Netlify deploy preview

https://deploy-preview-44253--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8667997

@zanivan zanivan marked this pull request as ready for review October 31, 2024 13:34
@zanivan
Copy link
Contributor Author

zanivan commented Oct 31, 2024

@siriwatknp one last thing, would it be possible to add the template titles to the ToC?

Something like this example:
Screenshot 2024-10-31 at 10 35 28

@@ -68,7 +68,7 @@ export default function AppNavbar() {
Dashboard
</Typography>
</Stack>
<ColorModeIconDropdown />
<ColorModeIconDropdown data-screenshot="" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I’m not mistaken, it’s for the screenshot script work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I didn't found any other occurrence of data-screenshot="", only data-screenshot="toggle-mode" and data-screenshot="toggle-default-theme", that's why I was asking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need @siriwatknp to answer this then haha

Copy link
Member

@siriwatknp siriwatknp Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove the data-screenshot from this button (in mobile) because there are two of them (desktop and mobile) on the page. Playwright was not happy with it.

@zanivan zanivan merged commit ae45564 into mui:master Nov 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants