Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Fix Sign-in/Sign-up templates layout #44281

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 31, 2024

Fixes layout in Sign-in and Sign-up templates according to @oliviertassinari's feedback in item 9 from #42609

👉 https://deploy-preview-44281--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Oct 31, 2024
@zanivan zanivan self-assigned this Oct 31, 2024
@mui-bot
Copy link

mui-bot commented Oct 31, 2024

Netlify deploy preview

https://deploy-preview-44281--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5c1c66e

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume you're leaving the sign-in side template fix for another PR.

Screenshot 2024-10-31 at 16 34 26

@@ -228,6 +214,18 @@ export default function SignIn(props: { disableCustomTheme?: boolean }) {
>
Sign in with Facebook
</Button>
<Typography sx={{ textAlign: 'center' }}>
Don&apos;t have an account?{' '}
<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No introduced in this PR, but this span is not required.

@zanivan
Copy link
Contributor Author

zanivan commented Oct 31, 2024

Looks good. I assume you're leaving the sign-in side template fix for another PR.

Yep, will change this one to be Sign-up side instead, so will tackle everything at once in a future PR 😅

@zanivan zanivan merged commit e7783b5 into mui:master Nov 1, 2024
22 checks passed
@aarongarciah aarongarciah mentioned this pull request Nov 6, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants