[docs-infra] Fix ad in RTL #44345
Merged
[docs-infra] Fix ad in RTL #44345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
fix-rtl-ad
branch
from
db08c15
to
a2490f8
Compare
Netlify deploy previewhttps://deploy-preview-44345--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a regression, it was working fine in v4: https://v4.mui.com/getting-started/installation/. It's a quick win, to get us closer to peak execution. RTL docs needs to look correct to have credibility with RTL. I noticed this in mui/mui-x#15072.
Regressions like #41239 are red flags for RTL users (I have seen a few more problems with icons and spacing).
Before: https://mui.com/material-ui/react-button/
After:
