[core] Fix webpack capitalization #44352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
oliviertassinari
added a commit
to mui/base-ui
that referenced
this pull request
Nov 9, 2024
oliviertassinari
commented
Nov 9, 2024
Comment on lines
36
to
+39
| 'Codesandbox ': CodeSandbox | ||
| code sandbox: CodeSandbox | ||
| Stackblitz: StackBlitz | ||
| Webpack: webpack # https://twitter.com/wSokra/status/855800490713649152 |
There was a problem hiding this comment.
Make sure this won't regress (the true value of this PR)
samuelsycamore
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://twitter.com/wSokra/status/855800490713649152 for why.
I feel like this helps us be more credible, e.g. https://rspack.dev/guide/migration/webpack or https://turbo.build/pack/docs/migrating-from-webpack use the official branding and makes me feel like we would better communicate to people this feeling:
https://x.com/lukeed05/status/1829527267162345651