Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Pigment CSS install #44353

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 9, 2024

Same as mui/pigment-css#292. There is no next tag on

so for sure it won't work.


A general rule of thumb I follow all the time:

  1. Setup VS Code to have all the MUI org's codebase
SCR-20241109-nvuc
  1. Search the codebase for similar problems

I'm not super confident about those probabilities, but it feels like this: 90% of the time community contributor PR's authors don't do this. And 30% of the time we fix only part of the issue because if we did, we would have found more. So I now systematically do it, so I think it's a best practice for maintainers too.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/* labels Nov 9, 2024
@mui-bot
Copy link

mui-bot commented Nov 9, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 79724a5

@mnajdova mnajdova merged commit c17491e into mui:master Nov 12, 2024
24 of 25 checks passed
@oliviertassinari oliviertassinari deleted the pigment-css-fix-docs branch November 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants