Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove old marked JS options #44375

Merged
merged 5 commits into from
Nov 12, 2024
Merged

[core] Remove old marked JS options #44375

merged 5 commits into from
Nov 12, 2024

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Nov 11, 2024 •
edited
Loading

Remove the old Marked js options https://marked.js.org/using_advanced#options

@ZeeshanTamboli ZeeshanTamboli added the core Infrastructure work going on behind the scenes label Nov 11, 2024
@mui-bot
Copy link

mui-bot commented Nov 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44375--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 066e407

@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove old marked options [core] Remove old marked JS options Nov 11, 2024
@ZeeshanTamboli ZeeshanTamboli marked this pull request as draft November 11, 2024 07:30
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review November 11, 2024 07:53
@ZeeshanTamboli ZeeshanTamboli requested a review from a team November 11, 2024 07:53
mnajdova
mnajdova reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which version were these options removed? You are referencing the docs, but we are not on the latest version (we have "marked": "^14.1.4", as a dependency) and the latest version is "15.0.0"

@ZeeshanTamboli
Copy link
Member Author

ZeeshanTamboli commented Nov 12, 2024 •
edited
Loading

In which version were these options removed? You are referencing the docs, but we are not on the latest version (we have "marked": "^14.1.4", as a dependency) and the latest version is "15.0.0"

v15 was released just 3 days ago. The options were removed in v8.0.0. The linked docs also mention the version when it was removed ( see the "Notes" column in the Old options section).

@mnajdova
Copy link
Member

The linked docs also mention the version when it was removed ( see the "Notes" column in the Old options section).

Ah nice, I missed this section.

@ZeeshanTamboli
Copy link
Member Author

@mnajdova or @mui/docs-infra Can you give a review?

mnajdova
mnajdova approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I wanted to double check that tables still work :)

@ZeeshanTamboli ZeeshanTamboli merged commit 015db15 into mui:master Nov 12, 2024
22 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-redundant-marked-options branch November 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeeshanTamboli @mui-bot @mnajdova