[styled-engine-sc] Fix missing @types/hoist-non-react-statics causing styled returns any
#44397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
…ng `styled` returns any
megos
force-pushed
the
fix/styled-engine-sc-types-fix
branch
from
c493fb9
to
1333ef8
Compare
Netlify deploy previewhttps://deploy-preview-44397--material-ui.netlify.app/ Bundle size report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved
@types/hoist-non-react-staticsfrom devDependencies to dependencies.The type definitions for
styled-engine-scdepend onhoist-non-react-statics.material-ui/packages/mui-styled-engine-sc/src/index.d.ts
Line 3 in 4732610
The
@types/hoist-non-react-staticsis not included in the dependencies, if this type definition is not installed,styledwould return any.I tried this in Material UI + CRA + styled-components (TypeScript) repository.
I re-created this PR because the CI is stuck.
#43730 (comment)