update (docs): note working with cypress #44958
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhutMinhIT
commented
Jan 7, 2025
•
NhutMinhIT
commented
- I have followed (at least) the PR section of the contributing guide.
Signed-off-by: Nguyen Nhut Minh <[email protected]>
Netlify deploy previewBundle size report |
Signed-off-by: Nguyen Nhut Minh <[email protected]>
mj12albert
reviewed
Jan 8, 2025
| @@ -205,6 +205,7 @@ If you use the ListSubheader directly, **no additional code is required**. | |||
| To properly label your `Select` input you need an extra element with an `id` that contains a label. | |||
| That `id` needs to match the `labelId` of the `Select`, for example: | |||
| - Note: When working with `cypress testing`, this element is rendered in a different location in the DOM (possibly a virtual dom), you can use `id` to identify the test element. | |||
There was a problem hiding this comment.
This doesn't feel right to me, data-testid should work for a simple Select interaction with cypress, see #44939 (comment) @NhutMinhIT
oliviertassinari
requested changes
Jan 8, 2025
There was a problem hiding this comment.
See https://github.com/mui/material-ui/issues?q=label%3A%22component%3A+select%22+label%3Atest+is%3Aclosed for historical guidance on how to test with Cypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.