Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Drawer] Deprecate *Props and complete slots, slotProps #44960

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[material-ui][Drawer] Deprecate *Props and complete slots, slotProps #44960

wants to merge 16 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 7, 2025 •
edited
Loading

Part of #41281, blocked by #44959

This PR also include SwipeableDrawer because it has Drawer as a direct dependency.

  • Deprecate BackdropComponent, BackdropProps, ModalProps, PaperProps, SlideProps.
  • Adopt mergeSlotProps to handle callbacks properly.
  • Added a codemod (tested by transforming the drawer demos)

@siriwatknp siriwatknp added on hold There is a blocker, we need to wait component: drawer This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material component: SwipeableDrawer The React component. labels Jan 7, 2025
@mui-bot
Copy link

mui-bot commented Jan 7, 2025 •
edited
Loading

Netlify deploy preview

SwipeableDrawer: parsed: +0.97% , gzip: +0.85%
Drawer: parsed: +0.92% , gzip: +0.77%
@material-ui/core: parsed: +0.12% , gzip: +0.12%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f56cf29

@siriwatknp siriwatknp removed the on hold There is a blocker, we need to wait label Jan 8, 2025
@siriwatknp siriwatknp mentioned this pull request Jan 8, 2025
Open
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siriwatknp @mui-bot