Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix bundler tests and cover @mui/material-nextjs #44966

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 7, 2025

  • Fix a regression in bundler tests caused by a change in pnpm pack output
  • Add @mui/material-nextjs to the fixture. We've been seeing issues when moving to ESM exports with this package as it imports a cjs-only module from next. This improved coverage of this edge case while upgrading our package layout
  • Add react@18 for next+webpack4 fixture. (We can probably think about deprecating support for webpack 4)

@mui-bot
Copy link

mui-bot commented Jan 7, 2025

Netlify deploy preview

https://deploy-preview-44966--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 08925ca

@Janpot Janpot added the test label Jan 7, 2025
@Janpot Janpot marked this pull request as ready for review January 7, 2025 17:33
@Janpot Janpot changed the title Fix bundler tests and update next to use @Mui/material-nextjs [code-infra] Fix bundler tests and update to cover @mui/material-nextjs Jan 7, 2025
@Janpot Janpot changed the title [code-infra] Fix bundler tests and update to cover @mui/material-nextjs [code-infra] Fix bundler tests and cover @mui/material-nextjs Jan 7, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2025
@zannager zannager requested a review from JCQuintas January 8, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants