[material-ui][Alert] complete slots and slotProps
#44971
+197
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
35 tasks
Netlify deploy previewhttps://deploy-preview-44971--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
sai6855
approved these changes
Jan 8, 2025
DiegoAndai
reviewed
Jan 8, 2025
| @@ -191,6 +191,7 @@ const Alert = React.forwardRef(function Alert(inProps, ref) { | |||
| const classes = useUtilityClasses(ownerState); | |||
|
|
|||
| const externalForwardedProps = { | |||
| ...other, | |||
There was a problem hiding this comment.
So that the useSlot can handle the component prop (in …other) properly for the root slot.
siriwatknp
commented
Jan 9, 2025
| @@ -64,7 +64,7 @@ export interface ConformanceOptions { | |||
| testStateOverrides?: { prop?: string; value?: any; styleKey: string }; | |||
| testCustomVariant?: boolean; | |||
| testVariantProps?: object; | |||
| testLegacyComponentsProp?: boolean; | |||
| testLegacyComponentsProp?: boolean | string[]; | |||
There was a problem hiding this comment.
Need to add this to be able to test specific slot of components.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing slots:
root,icon,messageand `action.