Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table #45056

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[docs][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table #45056

wants to merge 11 commits into from
+30 −0

Conversation

MachaVivek
Copy link

Table before the changes
Screenshot 2025-01-19 160616

Table after the changes
Screenshot 2025-01-19 163628

Files where the code is changed

material-ui/docs/data/material/components/table/StickyHeadTable.tsx

closes #34416

@MachaVivek MachaVivek changed the title [material-ui][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table #34416 [material-ui][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table Jan 19, 2025
@mui-bot
Copy link

mui-bot commented Jan 19, 2025 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 468e4b3

@zannager zannager added the component: table This is the name of the generic UI component, not the React module! label Jan 20, 2025
ZeeshanTamboli
ZeeshanTamboli requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unexpected file changes before we review this PR.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Jan 23, 2025
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table [docs][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table Jan 23, 2025
@MachaVivek
Copy link
Author

MachaVivek commented Jan 23, 2025 •
edited
Loading

Remove the unexpected file changes before we review this PR.

Here unexpected means the files not related to table component
Please explain

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jan 23, 2025 •
edited
Loading

Remove the unexpected file changes before we review this PR.

Here unexpected means the files not related to table component Please explain

Yes correct. Remove files not related to the Table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap Awaiting requested review from bharatkashyap

@ZeeshanTamboli ZeeshanTamboli Awaiting requested review from ZeeshanTamboli

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Table] Scrollbar extends into header when using stickyHeader on Table component
4 participants
@MachaVivek @mui-bot @ZeeshanTamboli @zannager