[material-ui][Table] Fixed Hover Background - Value Provided is Out of Range and update tests #45069
+103
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45069--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reproduced the issue in personal project by installing and using the "@mui/material"
The error in the console is
The wrote the test file for testing the issue with edge case
the tests output is below
Then changed the code related to the hoverOpacity and selectedOpacity in the file
/material-ui/packages/mui-material/src/TableRow/TableRow.js
Again checked the tests the output for the test is below
closes #29084