[material-ui][Button] Apply id only if loading indicator is present #45296
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
component: button
aarongarciah
changed the title
Netlify deploy previewhttps://deploy-preview-45296--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
1 task
aarongarciah
commented
Feb 13, 2025
aarongarciah
commented
Feb 13, 2025
| const loader = | ||
| typeof loading === 'boolean' ? ( | ||
| let loader = null; | ||
| let computedId = idProp; |
There was a problem hiding this comment.
If there's no loading present, we just use the id prop. loadingId always has a value (idProp or generated using useId)
aarongarciah
force-pushed
the
button-conditional-loading-id
branch
from
7c4d446 to
34e25af
Compare
DiegoAndai
reviewed
Feb 13, 2025
There was a problem hiding this comment.
This makes sense, but I would like to have @siriwatknp's review next week, as he is more familiarized with potential edge cases.
Should we cherry-pick this to v6?
aarongarciah
added
the
cherry-pick
|
@DiegoAndai I just added the cherry-pick label |
DiegoAndai
added
v6.x
needs cherry-pick
|
@aarongarciah the "cherry-pick" one is for PRs that are cherry-picked. I updated the labels 😊. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced an
idattribute in all buttons when we introduced theloadingprop in theButtoncomponent (#44637). We've got a couple of reports that some tests were broken because of this: #44637 (comment)This PR changes the logic so the
idattribute is only added when the loading indicator is present.