Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snackbar] - fix button position with long texts #4677

Closed
wants to merge 1 commit into from
Closed

[Snackbar] - fix button position with long texts #4677

wants to merge 1 commit into from

Conversation

avocadowastaken
Copy link
Contributor

  • PR has tests / docs demo, and is linted.
  • [ x Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fix for #4676

@mpontikes
Copy link

@oliviertassinari Can you review this PR?

@avocadowastaken
Copy link
Contributor Author

@mpontikes it has problems in ff, need to replace with flex maybe

@nathanmarks nathanmarks added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Aug 2, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 2, 2016

I only had a quick view at this PR.
Do we really want to display ... when the text is too long?
From the specification, I think that we should increase the height of the Snackbar.
Hence, looks like the root issue is the same as #4294.

Regarding a proper fix, I think that we should stop forcing the height of the element, take advantage of the browser layout CSS engine and use a bottom: 100% transform for the open / close stuff.

@avocadowastaken
Copy link
Contributor Author

avocadowastaken commented Aug 2, 2016

@oliviertassinari big 👍 For this,

I didn't wanted to bother about multiple lines in this PR because there is another issue about multi line snack bar, so I just add '...' At the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants