MenuItem Fix hoverColor muiTheme override #4957
Conversation
…he menuItem.hoverColor in muiTheme.
muibot
added
PR: Needs Review
PR: needs revision
| @@ -297,6 +297,7 @@ class MenuItem extends Component { | |||
| ref="listItem" | |||
| rightIcon={rightIconElement} | |||
| style={mergedRootStyles} | |||
| hoverColor={this.context.muiTheme.menuItem.hoverColor} | |||
There was a problem hiding this comment.
The other properties are alphabetically sorted. Might be a coincidence for all I know.
| @@ -28,7 +28,7 @@ function getStyles(props, context, state) { | |||
| const {listItem} = muiTheme; | |||
|
|
|||
| const textColor = muiTheme.baseTheme.palette.textColor; | |||
| const hoverColor = fade(textColor, 0.1); | |||
| const hoverColor = props.hoverColor || fade(context.muiTheme.baseTheme.palette.textColor, 0.1); | |||
There was a problem hiding this comment.
Why not keeping the textColor?
oliviertassinari
force-pushed
the
master
branch
from
53b828e to
ea2538e
Compare
|
Looks like there is another PR opened for the same issue #5000. It would be great to join forces to address the issue. |
| @@ -291,6 +291,7 @@ class MenuItem extends Component { | |||
| <ListItem | |||
| {...other} | |||
| disabled={disabled} | |||
| hoverColor={this.context.muiTheme.menuItem.hoverColor} | |||
There was a problem hiding this comment.
Oh right, I get it now muiTheme.menuItem.hoverColor is unused as we are speaking 😨 .
|
Any update on this? I need this fix for my current project. I'd be happy to help if I can. |
|
@oliviertassinari I consider it a fix because it's a property that can be set when customizing the theme, but setting that property has no effect because the component itself hard-codes it based on the text color. Is that not a bug? I need to be able to set the hover color independently of the text color. I understand #5000 is also addressing this issue. I was just wondering if I could be any help getting one of them in. |
|
@garrettn Oh right, thanks for the context. |
|
I opened a new PR at #5502. |
Fix the MenuItem hoverColor override when specified. muiTheme.menuItem.hoverColor had no effect. Passes hoverColor to ListItems if muiTheme.menuItem.hoverColor specified. Fix closes #4227