[TimePicker] Remove the call to onDismiss when already calling onAccept #5213

nihaux · 2016-09-18T23:57:47Z

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #5211.

oliviertassinari · 2016-09-20T21:20:17Z

src/TimePicker/TimePickerDialog.spec.js

+import React from 'react';
+import {shallow} from 'enzyme';
+import {expect} from 'chai';
+import sinon from 'sinon';


Would be better to use import {spy} from 'sinon';

oliviertassinari · 2016-09-22T21:55:20Z

@nihaux That looks good to me. We should make sure the TimePicker API is more consistent with the other components 👍 .

Merge branch 'master' into fixPopoverIOS # Conflicts: # src/Popover/Popover.spec.js Merged branch master into master IOS detection in Popover detect IOS devices in Popover component to fix popover positioning Merge pull request #4168 from Havdon/Menu-scroll-lock [Menu] Stop wheel events from propagating if scroll container is scrollable. Merge pull request #4755 from audetpascale/patch-1 [DropDownMenu] Do not wrap below dropdown menu. Merge pull request #5661 from frooeyzanny/list-padding [List] Edit padding in styles object. Edit List padding Merge pull request #5657 from oliviertassinari/enhanced-button-fix-focus [EnhancedButton] Fix an accessibility issue [EnhancedButton] Fix an accessibility issue This is a continuation of #4678. Thanks @tdtds for raising this issue As it turns out, we also had this issue on the `next` branch: #5656 Fix #4678. Merge pull request #5655 from oliviertassinari/auto-complete-on-close [AutoComplete] Add an onClose callback property [AutoComplete] Add an onClose callback property This is a continuation of #5294. Thanks @alexprice91 for the original PR. Fix #5294. Merge pull request #5654 from oliviertassinari/text-field-error-style-fix [TextField] Fix errorStyle priority [TextField] Fix errorStyle priority This is a continuation of #4756. Thanks @andrewdormi for the PR. Fix #4756. Merge pull request #5653 from oliviertassinari/drop-down-menu-on-close [DropDownMenu] Add an onClose callback property [DropDownMenu] Add an onClose callback property This is a continuation of #4378. Thanks @liesislukas for the original PR. Fix #4377 Merge pull request #4762 from audetpascale/patch-2 [MenuItem] Add right padding when there is icon. [AutoComplete] Add the test back after the revert Merge pull request #5627 from markwain/Revert-AutoComplete-Fire-onUpdateInput-when-an-item-from-the-dropdown-is-selected [AutoComplete] Revert - Fire onUpdateInput when an item from the dropdown is selected Merge pull request #5630 from Dilatorily/list-style-icon-menu [IconMenu] Add listStyle prop Merge pull request #5631 from Dilatorily/list-style-select-field [SelectField] Add listStyle prop [SelectField] Add listStyle prop [IconMenu] Add listStyle prop Revert "[AutoComplete] Add unit test for change", "[AutoComplete] Fire onUpdateInput when an item from the dropdown is selected" This reverts commit f448f4698e2ae7c2ac067aea2a47b81aa42f0d25. [makeSelectable] Fix missing check for existence of `onChange` (#5589) [docs] fix typo with sentence for AutoComplete (#5596) Merge remote-tracking branch 'callemall/master' Merge pull request #5582 from oliviertassinari/v0.16.4 [release] v0.16.4 [release] v0.16.4 [npm] Rollback the react dependency path to v15.0.0 Merge pull request #5580 from oliviertassinari/v0.16.3 [release] v0.16.3 [release] v0.16.3 Merge pull request #5575 from oliviertassinari/react-v15.4.0 [docs] Upgrade to v15.4.0 [docs] Upgrade to v15.4.0 Merge pull request #5566 from vinzscam/listitem-fix-hover [ListItem] Fix hover on touch devices Merge pull request #5572 from timbur/patch-1 include `react-tap-event-plugin@^2.0.0` for `react@^15.4.0` include `react-tap-event-plugin@^2.0.0` for `react@^15.4.0` [ListItem] Fix hover on touch devices [core] Add support for Webpack 2/Rollup tree shaking (#5545) * Add support Webpack 2/Rollup tree shaking * Add custom `babel-es2015-preset`, Transpile `index.js` file with `babel` * Move `material-ui-babel-es2015-preset` from `packages` to `tools` Merge pull request #5550 from oliviertassinari/v0.16.2 [release] v0.16.2 Merge remote-tracking branch 'callemall/master' Move `material-ui-babel-es2015-preset` from `packages` to `tools` [docs] Compress the images (#5552) I hope it's gonna help reducing the repository size increase over time. [release] v0.16.2 [TextField] Remove the isClean logic (#5540) Following #3450, I'm removing the isClean logic as React have now deprecated switching for controlled / uncontrolled component. As it turns out, for some reason, it's fixing #4430. @joewalker Could you confirm? I was able to reproduce your issue. Controlling the TextField inside a Dialog triggers a double render the first time making the cursor jump. Closes #4430. [IE] Remove the unsupported initial property (#5539) Add custom `babel-es2015-preset`, Transpile `index.js` file with `babel` Add support Webpack 2/Rollup tree shaking Merge pull request #5536 from gdorsi/raised_button_set_touched_state_on_touchend [RaisedButton] Fix hover on touch devices Merge pull request #5537 from oliviertassinari/npm-upgrade-7 [npm] Upgrade the dev dependencies [npm] Upgrade the dev dependencies Set on true the touched state in RaisedButton also in handleTouchEnd Merge pull request #5535 from oliviertassinari/grid-title-titleStyle [GridTitle] Add a titleStyle property [GridTitle] Add a titleStyle property This is a continuation of #5317. Thanks @sottar for it! Closes #5317 [AutoComplete] Add a test for popoverProps [AutoComplete] Fix Popover's style overriding popoverProps Merge pull request #5528 from Pczek/master [ListItem] Clear hover state if componet get's disabled fixed formatting which cause travis to fail in pull request #5528 added unit test for pull request #5528 if ListItems get's disabled, also release hover state Merge pull request #5520 from dantix/warning-table-children [Table] Warning on rendering attempt of unsupported child [Card] closeIcon and openIcon customizable in Card, fix #5488 (#5513) Add the possibility to change the expandable button Icon in the Card component, this gives more opportunity to customize the component and solves #5488. [Stepper] Improve the test after #5507 Merge pull request #5507 from lawrence-yu/master [Stepper] Add iconContainerStyle to StepButton and StepLabel [TimePicker] Improve the test after #5511 Merge pull request #5511 from Gerigot/timepicker-autook-fix [TimePicker] `autoOk` closing the dialog too early, fix #5499 Added unit tests for iconContainerStyle in StepButton and StepLabel [TimePicker] autoOk fix added test a unit test added to test the touchEnd and mouseUp event management fixed test Warning on rendering attempt of unsupported child Card close and open icon custom changed to defaultProps instead of using a function in cardExpandable.js added dots where they where missing The list item commit is only because the lint script gives to me an error so I decided to add also this correction ( only two spaces removed ) added 1 integration test Merge pull request #5518 from paol/Fix-bug-3359 [AutoComplete] Fire onUpdateInput when an item from the dropdown is selected [AutoComplete] Add unit test for change [AutoComplete] Fire onUpdateInput when the user selects an item from the dropdown. This was the only situation where the `searchText` state was being set without firing the corresponding `onUpdateInput` event. This caused bugs when attempting to use AutoComplete as a controlled component. [IconMenu] Removing the deprecation as not ready The `iconStyle` property is also used by the `AppBar` component. We would need to fix it here too. Merge pull request #5515 from oliviertassinari/toolbar-align-item-center [ToolbarGroup] Fix vertical alignment Merge pull request #5514 from oliviertassinari/list-item-control [ListItem] Fix an issue with the controlled behavior [ToolbarGroup] Fix vertical alignment This is a continuation of #5442. It's following the same approach than on the `next` branch. Thanks @colllin for raising this point. Closes #5442. [MenuItem] Fix a regression introduced by #5502 [ListItem] Fix an issue with the controlled behavior Closes #5500. Merge pull request #5502 from garrettn/ListItem-hoverColor [MenuItem][ListItem] Allow overriding hoverColor Changed autoOk example location changed from the complex example section to the simple managed also the autoOk fix for mobile device I added a control also in the handleTouch eventListener so that if it's touchend it will set the finished to true I also added an autoOk example timePicker [docs] Add one more resource around the style migration closeIcon and openIcon customizable in Card param was given but nobody was taking care about Add iconContainerStyle to StepButton and StepLabel [MenuItem] Pass hoverColor from the theme to the ListItem [ListItem] Use hoverColor prop [IconMenu] Small refactorisation after the merged PR Merge pull request #5496 from jpellizzari/4857-prop-warnings [IconMenu] Change IconMenu to conditionally merge button styles [IconMenu] Changed IconMenu to conditionally merge button styles Merge pull request #5490 from m14t/fix/no-fade-text-field-label [TextField] Add ability to style label color when a value is present [TextField] Simplify floatingLabel styling [TextField] Add a unit test following floatingLabelFocusStyle fix Merge pull request #5487 from paol/Fix-bug-5381 [TextField] Fix floatingLabelFocusStyle when floatingLabelFixed is true Merge pull request #5491 from oliviertassinari/docs-other-properties [docs] Add a note regarding other properties [docs] Add a note regarding other properties This is a continution of #5479. Thanks @jvhoven for raising it. The behavior for no documented properties has never been explicited. It's quite important for users and us to be consitant. Closes #5479. [TextField] Fix floatingLabelFocusStyle working incorrectly when floatingLabelFixed={true} Merge pull request #5474 from amangeot/toggle-label-props [Toggle] Fix label propTypes from `string` to `node` Toggle component's label props now expects React nodes instead of strings Merge pull request #5468 from oliviertassinari/floating-action-button-fix-regression [FloatingActionButton] Fix regression with n children [FloatingActionButton] Fix regression with n children Merge pull request #5466 from oliviertassinari/npm-upgrade-6 [npm] Upgrade the dev dependencies [npm] Upgrade the dependencies Merge pull request #5452 from oliviertassinari/grid-list-auto [GridList] Add the support for cellHeight="auto" [GridList] Add the support for cellHeight="auto" This is a continuation of #5051. I'm following @nathanmarks comment regarding allowing `'auto'`. Closes #5051. Closes #4492. Merge pull request #5431 from pinturic/pinturic-crema [docs] Add CReMa Added CReMa to Material-UI Specific Projects Merge pull request #5444 from oliviertassinari/popover-fix-anchorEl-invalid [Popover] Fix support for invalid anchorEl Merge pull request #5446 from oliviertassinari/fix-select-field-safari-10 [TextField] Fix wrong style behing applied to div elements Merge pull request #5434 from kutyel/patch-1 [ToolbarTitle] Take font family from base theme [TextField] Fix wrong style behing applied to div elements [Popover] Fix support for invalid anchorEl Take font family from base theme for ToolbarTitle [Tabs] Fix Firefox height issue This is a continuation of #4954. Thanks @dugokontov for the fix. I'm sorry the review took soo long. Closes #4954. [docs] Add redux-form in the Complementary Projects section They have a Material-UI example. The project seems quite popular. formsy-material-ui provides a different approach. Merge pull request #5429 from oliviertassinari/stepper-fix [Stepper] Fix children count method [Stepper] Fix children count method This is a continuation of #5407. Thanks @bennyhobart for raising this point! Closes #5407. Merge pull request #5413 from oliviertassinari/v0.16.1-prepare [release] prepare v0.16.1 [release] prepare v0.16.1 Merge pull request #5412 from oliviertassinari/text-field-multi-line-safari-10 [TextField] Fix leaking appearance property on a div [TextField] Fix leaking appearance property on a div I'm not really happy with this fix. The implementation has taken some wrong decisions. Anyway, it's much better in the `next` branch. Closes #5410. Merge pull request #5406 from oliviertassinari/table-footer-fix-adjustForCheckbox [TableFooter] Render the children independently of adjustForCheckbox [TableFooter] Render the children independently of adjustForCheckbox I'm glad the Table component was rewrote on the `next` branch. The `master` version is quite horrible :see_no_evil:. > It's an opinionated shitshow As would say @nathanmarks :joy:. Nevertheless, this fix is quite simple. Thanks @Serfenia and @florian-steffen for the original PRs. Closes #4296. Closes #4581. Closes #4582. Merge pull request #5405 from oliviertassinari/withWidth-SSR-fix [withWidth] Fix the SSR reconciliation [withWidth] Fix the SSR reconciliation Merge pull request #5404 from oliviertassinari/npm-upgrade-3 [npm] Upgrade the dependencies [npm] Upgrade the dependencies Merge pull request #5402 from oliviertassinari/dropdownmenu-false-child [DropDownMenu] Fix usage of null child [DropDownMenu] Fix usage of null child @smcguinness Thanks for the original PR This is a simple continuation Closes #5397 Merge pull request #5395 from oliviertassinari/icon-menu-improve-warning [IconMenu] Makes the warning message more explicit [IconMenu] Makes the warning message more explicit This change makes the warning less restrictive to fix: https://github.com/callemall/material-ui/commit/0ad7f2a2fa8badfb285bc88de8698273e9e0b04a#commitcomment-19315108. We focus on addressing the core issue. i.e having a better error message than > Warning: Unknown props `onKeyboardFocus`, when not using the API correctly. > Warning: Material-UI: You shoud not provide an <SvgIcon /> to the 'iconButtonElement' property of <IconMenu />. You should wrapped it with an <IconButton />. Merge pull request #5388 from lucasbento/improve-issues-template [GitHub] Improve ISSUE_TEMPLATE to ask for a running snippet [GitHub] Improve ISSUE_TEMPLATE to ask for a running snippet Many issues are being opened without user even knowing how to reproduce it, a bin would help a lot and also speed up collaborators work. Moving the comments about Stackoverflow and regular issues up may help to decrease the number of users asking non-related Material UI questions. [GitHub] Add link to template-ready webpackbin Merge pull request #5379 from DoubleU23/Menu/selectedTextColor [Menu] use 'muiTheme.menuItem.selectedTextColor' for 'style.selectedM… [ClickAwayListener] Improve the propTypes definition [Menu] use 'muiTheme.menuItem.selectedTextColor' for 'style.selectedMenuItem' As the 'selectedTextColor' is already set in the compiled theme we should use it. That way the user is able to overwride it. Merge pull request #5378 from lucasbento/revert-table-overflow-hidden-prop Revert "[TableRowColumn] Tooltip visible with TableRowColumn" Revert "[TableRowColumn] Tooltip visible with TableRowColumn" This reverts commit 252449d48007e1abe9f043166b0c9121fe25065c. Merge pull request #5374 from oliviertassinari/popover-animated-false [Popover] Add missing animated=false [Popover] Add missing animated=false @nathancahill Thanks for the original PR. I have added some tests and fixes some issues. Closes #5337. Merge pull request #5359 from lucasbento/add-tab-template-style [Tabs][TabTemplate] Add tabTemplateStyle prop to Tabs [Tabs][TabTemplate] Change TabTemplate to a stateless component & Add tabTemplateStyle prop to Tabs [TabTemplate] Fix style mutation warning [TabTemplate] Change templateStyle prop to just style [TabTemplate] Add unit test [TabTemplate] Change unit test to use assert.strictEqual instead of expect Merge pull request #5363 from oliviertassinari/docs-muiThemeable [docs] Document the muiThemeable HOC [docs] Document the muiThemeable HOC I have also removed some examples directly using the context. It's still considered an advanced feature of React. The community advises making it an implementation detail. It's what I'm doing here. Closes #5004. Merge pull request #5362 from oliviertassinari/fix-regression-floating-label [FloatingActionButton] Fix a regression on the children property Merge pull request #5360 from oliviertassinari/select-field-empty [MenuItem] Add min-height to MenuItem to allow null options in SelectItem Merge pull request #5361 from olanb7/update-iconmenu-docs [IconMenu] Updating error message for IconButton [FloatingActionButton] Fix a regression on the children property [IconMenu] Updating error message for IconButton Small fix, but it took me longer than it should have to figure out that this error was related to the IconMenu element. [MenuItem] Add min-height to MenuItem to allow null options in SelectItem Continuation of #5302. @jpetitcolas Thanks for the original PR. Closes #5302. Merge pull request #5246 from ashl1/fab_children_style_fix [FloatingActionButton] Fix overriding the style property on the children [m] use shallow() instead of mount() for Enzyme Merge pull request #5356 from lipenco/master [RefreshIndicator] - Fix Unknown props react warning [RefreshIndicator] fix unknown props react warning Merge pull request #5351 from oliviertassinari/fix-text-field-state [TextField] Fix a failing test with the controlled behavior [TextField] Fix a failing test with the controlled behavior [TextField] Add a failing test with the controlled behavior Merge pull request #4839 from warjet777/patch-1 [Popover] Making sure Popover has correct position Merge pull request #5342 from tim-mc/radiobuttongroup_valueselected [RadioButtonGroup] Modifying `selected` initial value check to account for falsy value Merge pull request #5336 from lvauvillier/showcase-lirelactu [docs] Add LireLactu to the showcase [RaisedButton] Add a overlayStyle property @PolGuixe Thanks. This is a continuation of your original PR. I'm not adding new tests as this component will soon be considered lagacy. Closes #5332. Merge pull request #5344 from marksweston/themes_docs_fix [docs] Fix non-compiling example code on Themes page [docs] Fix non-compiling example code on Themes page Modifying `selected` initial value check to account for falsy value [docs] Add LireLactu to the showcase Merge pull request #5077 from jkettmann/floating_action_button_set_touch_flag_on_touchend [FloatingActionButton] set touch flag in handleTouchEnd Merge pull request #5319 from oliviertassinari/v0.16.0 [release] v0.16.0 [release] v0.16.0 [docs] Remove the source map in production Merge pull request #5314 from dkwingsmt/patch-1 [Card] Do not pass CardHeader property subtitleColor to the DOM [Card] Do not pass CardHeader property subtitleColor to the DOM Using the subtitleColor property on CardHeader, react gives a warning "Warning: Unknown prop `subtitleColor` on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop" Note that the subtitleColor works properly, the header text is displayed in the given color, the only problem is the warning. Merge pull request #5313 from oliviertassinari/single-line-grid [docs] Add an One line example for GridLists [docs] Add an One line example for GridLists Thanks @sottar. Closes #5258. Closes #5300. [docs] Add react-dnd Follow #3103. This topic has quite some activity. I think it's great to lead the community in this direction. Merge pull request #5310 from oliviertassinari/lodash [npm] Remove the lodash dev dependency [npm] Remove the lodash dev dependency Merge pull request #5308 from feross/master [Core] Use lodash.merge/throttle for faster require() Use lodash.merge/throttle for faster require() Merge pull request #5282 from oliviertassinari/docs-add-casalova-related-project [docs] Add Casalova to the showcase [docs] Add Casalova to the showcase @clayne11 Following our discusion [here](https://github.com/callemall/material-ui/issues/4880#issuecomment-245427878). Merge pull request #5273 from luokuning/FixTypoInEslintrc Fixed typo in .eslintrc.js Fixed typo in .eslintrc.js [CONTRIBUTING] Add a playground link That's gonna help understanding issues. Merge pull request #5250 from oliviertassinari/0.16.0-rc2 [release] Prepare v0.16.0-rc2 [release] Prepare v0.16.0-rc2 Merge pull request #5248 from oliviertassinari/app-bar-composition [AppBar] Add a composition example [AppBar] Add a composition example Closes #5053. [FloatingActionButton] Fix applying inline style of children Merge pull request #5245 from oliviertassinari/appbar-clean-ontouchtap-handler [AppBar] Fix onTouchTap handler [AppBar] Fix onTouchTap handler Closes #2482. Closes #5238. Merge pull request #5244 from TeamWertarbyte/docs-carousel [Docs] Add material-auto-rotating-carousel to related projects [docs] Add material-auto-rotating-carousel to related projects. Merge pull request #5213 from Nihaux/issue#5211 [TimePickerDialog] fix #5211 invalid call to onDismiss Merge pull request #5236 from patitonar/patch-1 [Divider] Typo fix for Divider's page Typo fix for Divider's page forgotten import import spy not all sinon lib [TimePickerDialog] fix #5211 invalid call to onDismiss Merge pull request #5226 from m14t/fix/remove-unused-conditional [IconButton] Remove unused conditional [IconButton] Remove unused conditional It appears that this conditional was added in 77a3d71, but even at that time, there does not seem to be any calls to set the state of `hovered`, and so it it always `undefined` which means we always are entering this `if` block. Merge pull request #5221 from oliviertassinari/add-babel-runtime [core] Add babel-runtime to the release Merge pull request #5220 from oliviertassinari/tabs-add-some-test [Tabs] Add a test following the latest fix [core] Add babel-runtime to the release From my own test, the build folder is 4% smaller. The main advantage is probably at the runtime where the same modules are shared in memory by the browser. react-boostrap is following the same approach: https://github.com/react-bootstrap/react-bootstrap/blob/master/.babelrc#L9 @nathanmarks Would be great to have your feedback on this. [Tabs] Add a test following the latest fix Add a failing test fixed by #4635. [Divider][Subheader] Makes the implementation closer to next Merge pull request #4635 from mike-robertson/master [Tabs] Fix an edge case where children and value props change Merge pull request #5219 from smcguinness/patch-1 [Tabs] Fix onChange bubbling Merge remote-tracking branch 'upstream/master' Update to remove linting error during build Added onChange to the object deconstruction This fixes #5210 where all onChange events are bubbling up to Tabs. [CHANGELOG] Fix the formating for github Merge pull request #5206 from oliviertassinari/docs-server-side-rendering [docs] Update the server-rendering section Merge pull request #5207 from oliviertassinari/fix-peer-dependency [core] Use the ^15.0.0 as a dependency for react [core] Use the ^15.0.0 as a dependency for react Closes #4680. [docs] Update the server-rendering section Closes #3831. [Snackbar] Use the theme desktopGutter instead of hardcoded value Merge pull request #5203 from oliviertassinari/docs-required-knowledge [docs] Explicit the prerequisites section to required knowledge Merge pull request #5204 from oliviertassinari/npm-upgrade-docs [docs] Upgrade the npm dependencies Merge pull request #5205 from oliviertassinari/snackbar-content-style [Snackbar] Add a contentStyle property Merge pull request #5113 from matthewoates/master [Snackbar] Large screen snackbar does not cover up 100% width of screen anymore [Snackbar] Add a contentStyle property Closes #3190. [docs] Upgrade the npm dependencies [Docs] Explicit the prerequisites section to required knowledge @mbrookes Thanks for the suggestion. Closes #4513. [CHANGELOG] Update to the master state Merge pull request #5106 from agoldis/4088_switch_on_styling [Switch] Add thumbSwitchedStyle and trackSwitchedStyle [DatePicker] Improve the wording of the docs example @mehdijjz Thanks for the tip. TimePicker - add box-sizing to clock pointer mark style Merge pull request #5196 from oliviertassinari/raised-button-style [RaisedButton] Add a buttonStyle property [RaisedButton] Add a buttonStyle property I think that we should aim for having a customizability point for every inner element. Closes #5182. Merge pull request #5187 from oliviertassinari/datepicker-improve-i18n [DatePicker] Improve the i18n support [DatePicker] Improve the i18n support Closes #5101. Merge pull request #5172 from TeamWertarbyte/docs-chip-input [Docs] Add material-ui-chip-input to related projects Merge pull request #5165 from sidsarasvati/patch-2 Fixed typo in CHANGELOG Add material-ui-chip-input to related projects. Fixed typo in CHANGELOG Merge pull request #5159 from Thomas101/master [RaisedButton] Update file upload example Merge pull request #5161 from oliviertassinari/npm-upgrade-5 [npm] Upgrade the dependencies [npm] Upgrade the dependencies Also fix https://travis-ci.org/callemall/material-ui/builds/159391789 Merge pull request #5064 from cvinson/autocomplete-popover-props [AutoComplete] Add popoverProps to pass to Popover Update file input RaisedButton example This shows how to correctly embed a file input file into a RaisedButton ensuring that the file input remains clickable cross browser #3689 #4983 #1178 Merge pull request #5158 from oliviertassinari/popover-fix-callback-leak [Popover] Fix a callback leak [Popover] Fix a callback leak [CHANGELOG] Fix some minor thing after the latest pre-release Merge pull request #5155 from oliviertassinari/date-picker-improve-rtl-support [DatePicker] Improve the RTL support Merge pull request #5154 from oliviertassinari/improve-with-with-hoc [withWidth] Compute the width as soon as possible [withWidth] Compute the width as soon as possible Thank @PolGuixe for raising this point. Closes #5140. [DatePicker] Improve the RTL support [AppBar] Fix leaking property @chrislambe Thanks for raising this issue. Closes #5146. Merge pull request #5141 from oliviertassinari/update-changelog [CHANGELOG] Update to the current master state Update SnackbarBody.js [CHANGELOG] Update to the current master state Merge pull request #5119 from fzaninotto/patch-1 [doc] Add reference to admin-on-rest in showcase section Add reference to admin-on-rest in showcase section Large screen snackbar does not cover up 100% width of screen [Switch] Add thumbSwitchedStyle and trackSwitchedStyle Merge pull request #5102 from danep93/patch-1 README.md updated broken link Updated README.md Updated the link for "Override individual component styles via the style prop" . . . old link took you nowhere. Merge pull request #5079 from oliviertassinari/docs-style-customization [docs] Update the style section [docs] Update the style section [package] Follow the babel docs instructions Set the touch flag in FloatingActionButton also in handleTouchEnd Do not pass CardHeader property titleColor to the DOM Using the titleColor property on CardHeader, react gives a warning "Warning: Unknown prop `titleColor` on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop" Note that the titleColor works properly, the header text is displayed in the given color, the only problem is the warning. Closes #5047. Merge pull request #5067 from NoHomey/patch-1 [RaisedButton] Fixes #5065, Warning: Unknown props on <button> [RaisedButton] Fixes #5065, Warning: Unknown props on <button> [AutoComplete] Add popoverProps to pass to Popover Merge pull request #5054 from DanielRamosAcosta/refreshindicator-bugfix [RefreshIndicator] Passing other props to the root element, fixes #5034 [RefreshIndicator] Passing other props to the root element, fixes #5034 [Popover] Minor clean up after #5010 Merge pull request #5010 from BartKrol/select-field-disappear-fix [Popover] Prevent creating multiple timeouts when popover is closing [Popover] Prevent creating multiple timeouts when popover is closing Merge pull request #5036 from oliviertassinari/slider-refactorsation-clean-up [Slider] Clean up the implementation Merge pull request #5026 from oliviertassinari/rtl-invariant-style [RTL] Add a new directionInvariant property [Slider] Clean up the implementation Merge pull request #5035 from sufius/master Update Page.js Update Page.js Merge pull request #5025 from oliviertassinari/rename-make-selectable [List] Rename MakeSelectable to makeSelectable [RTL] Add a new directionInvariant property @denistakeda @aahan96 Can you have a look at this PR? Thanks. Closes #5021. Closes #5020. Closes #5001. Closes #4320. [List] Rename MakeSelectable to makeSelectable Closes #5022. Merge pull request #5024 from oliviertassinari/nested-list-render-null [NestedList] Prevent rendering the children when the nested list is hidden [NestedList] Prevent rendering the children when the nested list is hidden Thanks @zhangjunah for raising this issue. Closes #5007. Closes #5008. Merge pull request #5014 from aahan96/IconButton_Table [TableRowColumn] Tooltip visible with TableRowColumn Merge pull request #5016 from oliviertassinari/checkbox-different-shape [Checkbox] Tweak the transition to allow different shapes [TableRowColumn] Tooltip visible with TableRowColumn [Checkbox] Tweak the transition to allow different shape Merge pull request #5015 from mit-teaching-systems-lab/patch/enhanced-textarea-jsdom [EnhancedTextarea] Guard for if scrollHeight is not present [EnhancedTextarea] Guard for scrollHeight not being present [CHANGELOG] Add the latest breaking changes Merge pull request #4998 from yuhki50/fix-404-links [docs] Fix 404 links Fix 404 links Merge pull request #4994 from ninoraubaum/master [DatePicker] Changes opacity of disabled day-buttons [DatePicker] Changes opacity of disabled day-buttons to 0.4 [test] Reduce the noise when running the test suite Merge pull request #4951 from dugokontov/cancel-hover-on-disable-for-floating-action-button [FloatingActionButton] Reset hover state when disabled prop is changed [DatePicker] Changes opacity of disabled day-buttons [Button] Property disabled=true changes state hovered to false Merge pull request #4990 from oliviertassinari/icon-menu-warn-no-icon-button-child [IconMenu] Warn when not providing an IconButton to iconButtonElement Merge pull request #4987 from oliviertassinari/remove-deprecated-code-v0.16.0 [core] Remove the deprecated code for v0.16.0 Merge pull request #4988 from rafaelsales/master [ListItem] Fix primaryTogglesNestedList not working with checkbox #4753 [IconMenu] Warn when not providing an IconButton to iconButtonElement [ListItem] Fix primaryTogglesNestedList not working with checkbox #4753 [Core] Remove the deprecated code for v0.16.0 Merge pull request #4964 from oliviertassinari/roadmap-next [ROADMAP] Update after the v0.15.4 release Merge pull request #4982 from owencm/Bottom-Nav-Fix-2 [BottomNavigation] Fix SVG icon positioning Merge pull request #4978 from tantona/add-dearborn-denim-showcase [Docs] Add dearborn denim in the showcase Merge pull request #4980 from owencm/add-bottom-nav-to-index [BottomNavigation] Add the main component and it's Item to index Fix SVG icon positioning in BottomNavigation [ROADMAP] Update after the v0.15.4 release Add BottomNavigation and it's Item to index added dearborn denim showcase link Merge pull request #4973 from oliviertassinari/text-field-type-search [TextField] Better support for type=search [TextField] Better support for type=search Merge pull request #4941 from grxy/shorten-coveralls-command [core] shorten coveralls command [FloatingActionButton] Don't set current value of hovered state. [FloatingActionButton] Remove unnecessary assert. Merge pull request #4872 from oliviertassinari/remove-prop-types-build [core] Get rid of the all the propTypes in production Merge pull request #4955 from grxy/popover-animation-default-name [PopoverAnimationDefault] update component name to reflect file name Merge pull request #4940 from mpontikes/examples-update [Examples] Updated both examples to latest push Merge pull request #4943 from aahan96/DatePicker_Theme [DatePicker] Changed background color for year selection [PopoverAnimationDefault] update component name to reflect file name [FloatingActionButton] Reset hover state when disabled prop is changed Merge pull request #4933 from oliviertassinari/v0.15.4-master [CHANGELOG] Update for v0.15.4 [CHANGEL0G] Update for v0.15.4 [DatePicker] Changed background color for year selection [core] shorten coveralls command [Examples] Updated both examples to latest push Merge pull request #4931 from oliviertassinari/bottom-navigation-closer-to-next [BottomNavigation] Makes us closer to the next branch [BottomNavigation] Makes us closer to the next branch Merge pull request #4846 from jacksonrayhamilton/bottom-navigation [BottomNavigation] Initial implementation [BottomNavigation] Add initial implementation [ListItem] Simplify the props: open tests Merge pull request #4850 from davincho/list-item-prog-open [ListItem] New property open to toggle nested list Merge pull request #4920 from zodiac/zodiac/fix-ExampleFloatingLabel-formatting [SelectField] Fix formatting in documentation Update ExampleFloatingLabel.js Merge remote-tracking branch 'callemall/master' [utils] Remove the double dots Revert "[DropDownMenu] Display the first item in case there's no one with the corresponding value" Closes #4891. This reverts commit ef888df008460e55df40e60c32250187ae617383. Merge pull request #4895 from mit-teaching-systems-lab/patch/slider-max-prop-changes [Slider] Fix bug with Slider percent not updating when max prop changes Merge pull request #4892 from oliviertassinari/snackbar-fix-font [Snackbar] Add a fontFamily Fix bug with Slider not updating when max prop changes [Snackbar] Add a fontFamily [docs] Add v0.15.3 to the versions.json [core] Get rid of the all the propTypes in production Merge pull request #4877 from mpontikes/roadmap [Docs] Added ES Instructions to Docs Added ES instructions to Docs Merge pull request #4876 from sidsarasvati/patch-1 Fixed a typo in CHANGELOG Update CHANGELOG.md Merge pull request #4869 from jacksonrayhamilton/slider-prop-types [Slider] Pass secret argument to PropTypes function [Slider] Pass secret argument to PropTypes function Fixes #4854 [ROADMAD] Upgrade from v0.15.3 to v0.15.x Merge pull request #4865 from oliviertassinari/release-update-for-v0.15.3 [CHANGELOG] Upgrade for the v0.15.3 release [CHANGELOG] Upgrade for the v0.15.3 release remove unneeded className attribute adding tests, consider open prop when mounting [CHANGELOG] Upgrade to the current master state Merge pull request #4856 from oliviertassinari/react-v.15.3.0 [React] Fix the warning of the latest release v15.3.0 [React] Fix the warning of the latest release v15.3.0 React has documented this issue: [fixing-the-false-positive](https://facebook.github.io/react/warnings/dont-call-proptypes.html#fixing-the-false-positive-in-third-party-proptypes). Closes #4854. Merge pull request #4853 from shraddha30/TextFieldStyleForAutoComplete [AutoComplete] Add a textFieldStyle property Changes the comment text Resolves eslint issue with react/sort-prop-types Merge pull request #4833 from sassanh/rtl-grid [GridList] Fixed rtl problem. Allows textField styles for Autocomplete component Fix eslint errors. Toggle open state of nested list dynamically after component did mount. ref #4803 Merge pull request #4840 from wuman/browsersync-typo [Docs] Fix typo fix typo Update Popover.js Making sure Popover has correct position When Popover gets initially rendered with this.props.open = true, the positioning is incorrect (as the logic never gets run). This is because this.componentDidUpdate() is handling the placement when it renders, but that method doesn't get called on the initial render. (https://facebook.github.io/react/docs/component-specs.html#updating-componentdidupdate) To fix this I added this.componentDidMount(). Fixed rtl support for GridList [Docs] Fix the wrong spelling of ExampleExpandable I have also changed the example to illustrate two features - The padding button adding with (https://github.com/callemall/material-ui/pull/4820) - Move the CardActions at the top with `expandable={false}` as we can see in the [spec]( https://material.google.com/components/cards.html#cards-behavior) Merge pull request #4820 from jdai8/fixBottomPadding [Card] Fix bottom padding Merge pull request #4822 from zalmoxisus/patch-1 [DropDownMenu] Display the first item in case there's no one with the corresponding value Merge pull request #4829 from oliviertassinari/ROADMAP-v0.16.0 [ROADMAP] Update to what the core team is working on [ROADMAP] Update to what the core team is working on [DropDownMenu] Display the first item in case there's no one with the corresponding value [Card] Fix bottom padding Merge pull request #4817 from oliviertassinari/auto-complete-fix-callback [AutoComplete] Call onNewRequest once the animation is done [AutoComplete] Call onNewRequest once the animation is done [Showcase] Add https://www.spouti.com Closes #4806 Merge pull request #4807 from barbu110/master [RadioButtonGroup] Fix propTypes to accept anything [RaisedButton] Fix the icon style override as done in #4754 Merge pull request #4754 from TristanJMcCormick/FlatButton-icon-styling [FlatButton] Merge styles prop for FontIcon node Fix propTypes for RadioButtonGroup to accept anything, as RadioButton does for "value" Merge pull request #4766 from BrandonSmith/BrandonSmith-patch-4667 Fix invalid `labelColor` being passed Fix invalid `labelColor` being passed [MenuItem] Add right padding when there is icon. ### Problem description The text of the menu item is below the right icon. ### Steps to reproduce 1. Create a dropdown menu with a fixed size. 1. Enter a long string as value of the menu item. 1. Add a right icon to the menu item. ### Versions Only tested on... - Material-UI: 0.15.2 - React: 15.1.0 - Browser: Pretty much all of them! [FlatButton] Merge styles prop for FontIcon node [CHANGELOG] Update to the current master state Merge pull request #4748 from codemonkey800/master [Docs] Replaces images on Card page with hosted images [DropDownMenu] Do not wrap below dropdown menu. ### Problem description The text is wrapping below the dropdown menu if the text is too long. ### Steps to reproduce 1. Create a dropdown menu with a fixed size. 1. Enter a long string as value. ### Versions Only tested on... - Material-UI: 0.15.2 - React: 15.1.0 - Browser: Pretty much all of them! Merge pull request #4745 from oliviertassinari/update-roadmap [ROADMAP] Remove addressed issues Merge remote-tracking branch 'upstream/master' Changed images used for card page to hosted image; added nature image from lorempixel [ROADMAP] Remove addressed issues Merge pull request #4652 from hhaidar/master [IE9] Switch from translate3d to translate for compatibility Merge pull request #4743 from Hybrid-Force/nested-list-toggle-cb [ListItem] Trigger onNestedListToggle callback after state update [NestedLevel] Remove some dead code Merge pull request #4744 from walkthunder/FixListItemBug [ListItem] Fix incorrect `nestedLevel` [ListItem] Fix incorrect `nestedLevel` [ListItem] Trigger onNestedListToggle callback after state update Merge pull request #4734 from bgpat/fix-4733 [Menu] TypeError: key is undefined #4733 Merge pull request #4729 from oliviertassinari/react-remove-dead-code [React] Remove a workaround as it was fixed in the React Core Merge pull request #4728 from oliviertassinari/text-field-fix-is-valid-again [TextField] False should be a valid value Fix for #4733 [React] Remove a bug work-around as it was fixed in the React Core Revert #4548 and keep the tests. Here is the fix at the React level https://github.com/facebook/react/pull/7125. @puranjayjain you might be interested in seeing this. [TextField] False should be a valid value Merge pull request #4705 from pomerantsev/circular-progress-improvements [CircularProgress] Update component API (breaking change) Merge pull request #4725 from oliviertassinari/fix-more-warnings [React] Fix more unknown properties warnings Update default sizes and add a notice in CHANGELOG.md [React] Fix more unknow properties warnings Closes #4681 Closes #4694 [MakeSelectable] Fix Unknown prop `selectedItemStyle` on <div> tag. Merge pull request #4702 from HiTask/feature/custom-animations-for-popover-based [AutoComplete and other Popover based elements] Animation property added to Popover based elements Merge pull request #4723 from oliviertassinari/list-fix-prefixer [List] Prefix the style properties [List] Prefix the style properties Merge pull request #4715 from aahan96/MenuItem_pointer [MenuItem] Added pointer cursor to menu items Merge pull request #4716 from daikikohara/snackbar-action-to-node [Snackbar] change the action's PropType to node [Snackbar] change the action's PropType to node [MenuItem] Added pointer cursor to menu items Merge pull request #4713 from Ehesp/patch-2 [Slider] Fix typo "fried" to "fired" [Slider] Fix typo "fried" to "fired" [CircularProgress] Update component API (breaking change) Resolves #4340 - Change meaning of "size" attribute: it's now the component's diameter in pixels. - Add "thickness" attribute: line thickness is no longer a multiple of diameter but an independent parameter (defaults to an absolute value). - Remove margins around the component. Fix naming of default animations animation property added to Popover based elements Merge pull request #4521 from oliviertassinari/eslint-find-new-rules [eslint] Add find-new-rules to keep track of new rules [eslint] Add find-new-rules to keep track of new rules Merge pull request #4675 from vizath/card-warnings [Card] Fix unknown props warnings Merge pull request #4685 from CremAlex/master [FloatingActionButton] Fix invalid 'backgroundColor' prop being passed [FloatingActionButton] Fix invalid 'backgroundColor' prop being passed Fix Card related react warnings Merge pull request #4475 from mbrookes/examples-move-to-own-repositories [Examples] Move to own repositories Merge pull request #4663 from oliviertassinari/switch-fix-asynchronisity [EnhancedSwitched] Fix asynchronisity issues Merge pull request #4669 from oliviertassinari/npm-upgrade-2 [Core] Upgrade to the latest versions [Core] Upgrade to the latest versions Merge pull request #4667 from pawsong/master [Button] Fix invalid props being passed Fix invalid props being passed Merge pull request #4665 from mbrookes/master [Docs] Add Chip back to `AppLeftNav`, make `href` links relative [Docs] Add Chip back to `AppLeftNav`, make `href` links relative Chip had been left out in #4560, and the absolute links would break when refering to a specific release, e.g. http://material-uo.com/v0.15.2/ [EnhancedSwitched] Fix asynchronisity issues Merge pull request #4661 from mbrookes/master [Docs] Add v0.15.1 & v0.15.2 to `versions.json` [Docs] Add v0.15.1 & v0.15.2 to `versions.json` Merge pull request #4658 from oliviertassinari/changelog-v0.15.2 Update changelog for 0.15.2 Update changelog for 0.15.2 Merge pull request #4573 from alitaheri/update-changelog Update changelog for 0.15.1 and 0.15.2 [IE9] Switch from translate3d to translate for compatibility [SelectField] Add the maxHeight property back to the example Merge pull request #4645 from stevewillard/patch-4 [SelectField] Add maxHeight prop to pass down to DropDownMenu [SelectField] Add maxHeight prop to pass down to DropDownMenu Merge pull request #4642 from matiaslarsson/patch-2 [AutoComplete] Use dataSourceConfig.text instead of value when rendering MenuItems from objects Merge pull request #4634 from oliviertassinari/text-field-fix-text-overlapping [TextField] Fix multi-line overflow Merge pull request #4530 from puranjayjain/listitem-secondarytextcolor-fix [Themes][ListItem] Secondary Text color is incorrect fix [AutoComplete] Use dataSourceConfig.text instead of value as primaryText when rendering AutoComplete menu item We were using itemValue instead of itemText which made the AutoComplete menu render the wrong property as primaryText. [Themes][ListItem] Secondary Text color is incorrect fix Merge pull request #4625 from hhaidar/fix-ie-props-access [IE] Move state props access into componentWillMount for IE9/10 [TimePicker] Move state props access into componentWillMount for IE9/10 [Tabs] Fix issue #4633, an edge case where children (rendered Tab elements) and value props change. [Tabs] Fix issue #4633, an edge case where children (rendered Tab elements) and value props change. Mike | update the Tabs component getTabs method to accept a conditional parameter of props (default value is this.props) which will then use that props to iterate over the children. Also changed the getSelectedIndex method to pass the props it receives in its parameters to getTabs. This solves and edge case where, in componentWillReceiveProps, the Tabs component receives a new active tab as well as a new set of tabs (props.children). Since this passes in newProps to getSelectedIndex, this will use the newProps.children (new tabs if they have changed) value over this.props.children (old tabs). [TextField] Fix multi-line overflow Continuation of #4620 Closes #4620 Closes #4276 Closes #4331 Merge remote-tracking branch 'callemall/master' Merge pull request #4631 from omerzach/patch-1 [SvgIcon] Fix typo in src/SvgIvon/SvgIcon.js [TextField] Move state props access into componentWillMount for IE9/10 Fix typo in src/SvgIvon/SvgIcon.js Update the 0.15.2 changelogs Merge pull request #4626 from oliviertassinari/button-disabled-reset [Button] Never allow a disabled button to be in a hovered state. [Button] Never allow a disabled button to be in a hovered state. Continuation of #4531. There are several cases where `onMouseLeave` (which normally unsets the `hovered` state won't be called). One of those is if you disable a button within the `onTouchTap` method. This check ensures that a button will never be disabled but have an internal hovered state. Closes #4531. Merge pull request #4621 from alitaheri/reapply-4561 [SvgIcon] Add themeable color Merge pull request #4624 from oliviertassinari/linear-progress-fix-width [LinearProgress] Fix calculating of getRelativeValue [Table] Move state props access into componentWillMount for IE9/10 [LinearProgress] Fix calculating of getRelativeValue Continuation of #4037. Thanks @marcel-ernst for the original PR! Closes #4037 Closes #4037 [DatePicker] Move state props access into componentWillMount for IE9/10 Merge pull request #4617 from oliviertassinari/slider-style [Slider] Add a sliderStyle property [Docs] Fix wrong link to the Tabs page Thanks @edmondpr for the fix. Closes #4619. [SvgIcon] Add themeable color Merge pull request #4618 from oliviertassinari/test-stub-console [FlatButton] Add a condition to check for zero in the label warning [FlatButton] Add a condition to check for zero in the label warning Continuation of #4601. As raised by @nathanmarks, stubing the console is often not a good idea. I have removed them to a more *unit test* approach. Closes #4601. Closes #4592. [Slider] Add a sliderStyle property Continuation of #4282. Closes #4282 Closes #4575. Closes #4258. Merge pull request #4613 from angelikatyborska/update-inline-style-prefixer [InlineStylePrefixer] Update to v2.0.0 Merge pull request #4616 from nathanmarks/fix-step-expand-safari [Stepper] Fix transition bug in safari, resolves #4578 [Docs] Wrap the ListExampleSettings for mobile devices Thanks @edmondpr for raising this issue. Closes https://github.com/callemall/material-ui/pull/4614. [Stepper] Fix transition bug in safari, resolves #4578 [InlineStylePrefixer] Update to v2.0.0 Fixes #4419 [Docs] Make the MobileTearSheet more responsive Closes #4609. Merge pull request #4607 from oliviertassinari/react-v15.2.0-warnings [Core] Fix invalid props being passed Merge pull request #4608 from puranjayjain/related-project-notification [Docs] Add a related project: react material ui notifications added related project react material ui notifications [Core] Fix invalid props being passed Merge pull request #4560 from aahan96/links [AppNavDrawer] Links added to components in Menu Merge pull request #4571 from lwansbrough/vertical-slider [Slider] Add support for vertical/reversible sliders Merge pull request #4605 from nathanmarks/react-15.2-fixes [Core] Update several components to fix invalid props being passed [Core] Update several components to fix invalid props being passed to html elements Merge pull request #4603 from oliviertassinari/npm-react-v15.2.0 [React] Upgrade React to v15.2.0 and some other dependencies [React] Upgrade React to v15.2.0 and some other dependencies Merge pull request #4596 from nathanmarks/fix-ie9-10-issues [ListItem][RadioButtonGroup] Fix error with props access in state assignment for ie9/10 [Slider] Added Y axis and reverse sliders Allow Y axis sliding Enable vertical slider Added reversible axis [Slider] Changed orientation of the normal y-axis. Added tests and examples. [Slider] Removed unnecessary function invocations Updated docs Added tests to test category [RadioButtonGroup] Move props access to componentWillMount for setting state, fixes #4223 [ListItem] Move props access for state initialization into componentWillMount, fixes #4042 Merge pull request #4537 from vizath/IE-polyfill-fix [ClickAwayListener] Add better support for IE11 Merge pull request #4564 from ruifortes/master [DropDownMenu] Remove Synthetic Event from pooling when used asynchronously Merge pull request #4584 from 100ideas/patch-2 [docs/themes.md] fix typo 'muTheme' -> 'muiTheme' [docs/themes.md] fix typo 'muTheme' -> 'muiTheme' Merge remote-tracking branch 'callemall/master' Update changelog for 0.15.1 and 0.15.2 Merge pull request #4570 from mbrookes/chip-add-to-index [Chip] Add to index Merge pull request #4557 from oliviertassinari/app-bar-fix-prop [AppBar] Improve props checking to be more resilient Merge pull request #4558 from aahan96/tabs [Tabs] Property description of initialSelectedValue updated for no initial selected tab [Chip] Add to index [Examples] Move to own repositories [Examples] Remove local examples [DropDownMenu] Remove Synthetic Event from pooling when used asynchronously calling event.persist() is needed as noted here https://facebook.github.io/react/docs/events.html#event-pooling [Tabs] Property description of initialSelectedValue updated for no intial tab selection. [AppBar] Improve props checking to be more resilient [AppNavDrawer] Links added to components in Menu Merge pull request #4548 from oliviertassinari/fix-render-to-layer-context [RenderToLayer] Fix an internal issue with React [RenderToLayer] Fix an internal issue with React Merge pull request #4507 from alitaheri/update-changelog Update changelog Update changelog Add better support for IE11 Merge pull request #4496 from yonixw/patch-1 [Styles] Check for nulls for RTL Merge pull request #4529 from chalisegrogan/fix-popover-doc-link [Popover] Fix documentation page link to Menu component [Popover] Fix documentation page link to Menu. Merge pull request #4170 from nktssh/cursor-styling-for-disabled-components [Form components] Set `cursor:not-allowed` style when disabled Merge pull request #4520 from oliviertassinari/react-fix-inconsistency [React] Fix minor spread inconsistency [React] Fix minor spread inconsistency Merge pull request #4510 from aahan96/radiobutton [RadioButton] Changed the value type to any [RadioButton] Changed the value type to any Merge pull request #4470 from aahan96/stepper [Stepper] Register clicks in Safari for Vertical non-linear example [Stepper] Register clicks in Safari for Vertical non-linear example Merge pull request #4497 from dmusicb/commentStyling [Docs][Examples] Fix comment spelling mistakes [Examples] Fix comment spelling mistake [Docs] Fix comment spelling mistakes [Examples] Fix comment spelling mistakes Check for nulls some values of a style can be nulls and doesnt need a replacement. we need to skeep them. Plese not that in the cases like 'direction' (#L44) we want replacment for null anyway. So only when we invoke function we check for null. Fix for this issue: https://github.com/callemall/material-ui/issues/4364 Merge pull request #4486 from mbrookes/svgicon-remove-unused-style [SvgIcon] Remove unused style assignment [Form components] Set `cursor:not-allowed` style when disabled Affects the following components: Checkbox, DatePicker, EnhancedTextarea, IconButton, ListItem, MenuItem, RadioButton, SelectField, Stepper, Table, TextField, Toggle [SvgIcon] Remove unused style assignment Merge pull request #4487 from mbrookes/svg-icon-support-color-attribute [SvgIcon] Add support for color attribute [SvgIcon] Add support for color attribute Merge pull request #4474 from CumpsD/patch-4 [MenuItem] Allow styles on lefticon in non-desktop mode Merge pull request #4478 from oliviertassinari/select-field-fix-other [TextField] Keep spreading properties when children is set Merge pull request #4479 from oliviertassinari/raised-button-full-width [RaisedButton] Fix the fullWidth regression [RaisedButton] Fix the fullWidth regression Merge pull request #4355 from nathantalewis/expose-additional-date-picker-style [DatePicker] Expose dialog container style Merge pull request #4447 from ryantemple/documentation-prod-build-error [Documentation] fixed webpack production build Merge pull request #4381 from ToxicSalt/calendar-year [DatePicker] Fix year overflow Merge pull request #4433 from mbrookes/docs-remove-dom-events [Docs] Don't document standard DOM events [TextField] Keep spreading properties when children is set [DatePicker] Fix year overflow alphabetize styles Update CalendarYear.js add prepareStyles [Docs] Don't document standard DOM events Merge pull request #4471 from oliviertassinari/app-bar-fix-style [AppBar] Fix a styling regression Allow styles on lefticon even in non desktop mode Currently it is only possible to style the icon if the entire MenuItem is in desktop mode. Be consistent with the right icon and allow styling. Merge pull request #4418 from mbrookes/dropdownmenu-fix-click-floatinglabel [TextField] Fix floatingLabelText intercepting click events [AppBar] Fix a styling regression Merge pull request #4464 from mbrookes/datepicker-fix-box-sizing [DatePicker] Fix weekTitleDayStyle [DatePicker] Fix weekTitleDayStyle Merge pull request #4454 from mbrookes/datepicker-fix-box-sizing [DatePicker] Fix layout when used with border-box [Calendar] Move prepareStyles to JSX Merge pull request #4442 from barakmitz/master [IconMenu][DropDownMenu] Add an animated property Merge pull request #4449 from ffxsam/badge-palette-fix [Badge] Fixed incorrect color usage (primary/accent were swapped) Merge pull request #4457 from mbrookes/enhancedbutton-fix-href-style [EnhancedButton] Fix href style [EnhancedButton] Fix href style `href` was added to the props destructure when linkButton was deprecated, so is no longer in `...other`. The style attrubute wasn't being applied as a result. Also fixed the `href` PropType. [DatePicker] Fix layout when used with border-box [IconMenu][DropDownMenu] Add an animated property Fixed color palette issue with Badge Merge pull request #4266 from 59naga/feat-3667 [AppBar] Add iconStyleLeft prop [Documentation] fixed webpack production build Merge pull request #4025 from andrejunges/master [FontIcon] Prevent parent components from overriding icon's `color` property Merge pull request #4423 from oliviertassinari/render-to-layer-cleanup [RenderToLayer] Cleanup Merge pull request #4424 from oliviertassinari/eslint-plugin-mocha [eslint] Add a mocha plugin to enforce good practices [DatePicker] Expose dialog container style [eslint] Add a mocha plugin to enforce good practices Merge pull request #4392 from mbrookes/selectfield-add-floatinglabelfixed [SelectField] Add support for floatingLabelFixed prop Merge pull request #4426 from oliviertassinari/docs-themes-fix-width [Docs] Fix layout broken for Themes example Merge pull request #4425 from oliviertassinari/readme-add-coverage-badge [README] Add a code coverage badge [Docs] Fix layout broken for Themes example Merge pull request #4111 from heretge/feature/autocomplete-source-keys [AutoComplete] Add text and value field keys for objects list dataSource [README] Add a code coverage badge [RenderToLayer] Cleanup Merge pull request #4386 from isnifer/patch-1 [Timepicker] Add explicit box-sizing to Clock component [TextField] Fix floatingLabelText intercepting click events [SelectField] Add support for floatiingLabelFixed prop `floatiingLabelFixed` was not supported - added. Move `...other` to the root component. Move the example descriptions to code comments in the examples. Remove unused file. Merge pull request #4416 from tomoya/accept-width-parameter [withWidth] Accept width optional parameter [withWidth] Accept width optional parameter * Define largeWidth & mediumWidth as options * Use largeWidth & mediumWidth instead of numeric value Merge pull request #3746 from goffreder/master [RaisedButton] Don't override SvgIcon color prop Merge pull request #4409 from oliviertassinari/avatar-fix-position [Avatar] Fix a layout regression [AutoComplete] Add text and value field keys for objects list dataSources [FontIcon] Stopped icon's color overwriting This PR should fix the multiple issues we have with some components AppBar, ToolbarGroup, ListItem overwriting FontIcon's color. [Avatar] Fix a layout regression Merge pull request #4380 from ruiaraujo/lodash [Core] Move to the normal lodash. Merge pull request #4394 from mbrookes/selectfied-fix-errortext-alignment [SelectField] Fix errorText position when no value selected [RaisedButton] Don't override SvgIcon color prop Fixed color property passing down to icon in RaisedButton component. Added unit testing. Fixes #3745 [SelectField] Fix errorText position when no value selected Also deprecate `selectFieldRoot` prop and replace with `menuStyle` Merge pull request #4389 from OmgImAlexis/patch-1 [Examples] Update Google Fonts Merge pull request #4395 from mbrookes/muithemeprivider-add-to-index [MuiThemeProvider] Add to index Merge pull request #4189 from piglovesyou/hotkey-focus [Menu] Add basic hotkey-focusing feature Merge pull request #4356 from nathantalewis/expose-additional-time-picker-styles [TimePicker] Expose two TimePickerDialog style props [MuiThemeProvider] Add to index [Examples] Update Google Fonts to use https Merge pull request #4329 from oliviertassinari/snackbar-add-new-test [Snackbar] Add a new test and fix it Merge pull request #4391 from mbrookes/datepicker-fix-docs-descriptions [DatePicker] Fix docs descriptions [DatePicker] Fix docs descriptions [Timepicker] Add explicit box-sizing to Clock component [Core] Move to the normal lodash. Using the modular lodash build is actually worse unless only one package is installled. Merge pull request #4372 from puranjayjain/listitem-theming-fixes [Listitem][Menu][Menuitem] Fix theme not propagating on update Merge pull request #4262 from oliviertassinari/examples-simplies [Examples] Simplify the examples [Listitem][Menu][Menuitem] Fix theme not propagating on update Merge pull request #4365 from mbrookes/avatar-remove-border [Avatar] Remove the border Merge pull request #4346 from oliviertassinari/button-improved-validation [Button] Save some bytes on the production build Merge pull request #4316 from nathanmarks/branching-updates [Core] Update package.json versioning on master and add info to CONTRIBUTING Merge pull request #4357 from matthewoates/master [Tabs] Fixes tabindex Merge pull request #4367 from Yaxian/issue/DatePicker/onDissmiss [DatePicker]Fix the issue about onDismiss function will fire by handleTouchTapOk [DatePicker]Fix the issue about onDismiss function will fire by handleTouchTapOk [Avatar] Remove the border [TimePicker] Expose two TimePickerDialog style props [Tabs] Fixes tabindex Merge pull request #4347 from oliviertassinari/picker-improve-proptypes [Pickers] Add some test regarding the expect value property [Examples] Simplifies the examples [Pickers] Add some test regarding the expect value property [Button] Save some bytes on the production build Merge pull request #4328 from Sekhmet/fix-dropdownmenu-callback [DropDownMenu] Add check if there is onChange prop before calling it. [Snackbar] Add a new test and fix it Merge pull request #4332 from stevewillard/patch-2 [Popover] Fix typo from innerWith to innerWidth [DropDownMenu] Add check if there is onChange prop before calling it. Fix typo from innerWith to innerWidth Merge pull request #4203 from nathanmarks/stepper-height-fix [Stepper][StepButton] Add more tests and fix an issue with StepButton event handlers Merge pull request #4209 from oliviertassinari/auto-complete-fix-leaking [AutoComplete] Fix filter property leaking Merge pull request #4306 from oliviertassinari/npm-upgrade [Core] Upgrade some npm dependencies Merge pull request #4299 from pradel/docs-responsive-stepper [Stepper] Fix vertical stepper on mobile [Core] Update package.json versioning on master and add info to CONTRIBUTING This commit bumps the master package.json to the next major alpha in order to represent the true version of the code currently on the branch. It also adds details to CONTRIBUTING pertinent to the use of master and other branches. [Core] Upgrading some npm dependencies Merge pull request #4311 from mbrookes/fab-fix-svg-icon-color [FloatingActionButton] Fix SvgIcon fill color Add basic hotkey-focusing feature to Menu [StepButton] Adjust tests to use callCount instead of calledOnce, calledTwice [ExpandTransitionChild][Stepper] Set height to "auto" in componentDidAppear and componentDidEnter, resolves #4179 [StepContent][ExpandTransition] Add transition props to StepContent so the animation is configurable, improve integration test [Stepper][StepButton] Add more tests and fix an issue with StepButton event handlers [FloatingActionButton] Fix SvgIcon fill color Merge pull request #4301 from nathanmarks/improve-travis-setup [travis] Update travis config to exit early on errors and only run codemod tests when needed Merge pull request #4302 from yerinle/fix-typo-branch [Docs] Fix typo in getting started usage fixing typo in getting started usage doc [travis] Update travis config to exit early on errors and only run codemod tests if commit is relevant [Stepper] Fix vertical stepper on mobile Merge pull request #4289 from oliviertassinari/time-picker-clean [TimePicker] Remove some dead code [TimePicker] Remove some dead code Merge pull request #4251 from tintin1343/timepicker-time-reset [TimePicker] Fix auto reset of time on window resize Merge pull request #4229 from mbrookes/muithemeprovider-muitheme-prop-optional [Themes] Fix MuiThemeProvider default theme [Themes] Fix MuiThemeProvider default theme need not be a required prop, as a default is provided Remove muiThemable from the docs in preparation for deprecating it in 0.16.0. Update and reorder the docs. [AppBar] Add iconStyleLeft prop (fix #3667) - Add export `getStyles` of app-bar.js for test Merge pull request #4265 from ratson/docs-fix-typos [Docs] Fix typos [Docs] Fix typos Merge pull request #4250 from ToxicSalt/datepicker-classname [DatePicker] Added className prop to DatePicker Merge pull request #4197 from mbrookes/enhanced-button-deprecate-linkbutton [Buttons] Deprecate linkButton property [Buttons] Deprecate linkButton property It is no longer necessary to set the `linkButton` prop with the href prop. Add missing `href` prop to IconButton Merge pull request #4122 from ryantemple/enhanced-button-focus [EnhancedButton] Fix not setting focus when keyboardFocused prop set Merge pull request #3946 from newoga/remove-react-addons-update [Core] Remove react-addons-update dependency Merge pull request #3870 from mbrookes/chip [Chip] New component Merged branch master into master

muibot added the PR: Needs Review label Sep 18, 2016

oliviertassinari reviewed Sep 20, 2016

View reviewed changes

nihaux force-pushed the issue#5211 branch from 39f9ef9 to 5db03f0 Compare September 21, 2016 13:02

muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Sep 21, 2016

nihaux added 2 commits September 22, 2016 13:13

[TimePickerDialog] fix mui#5211 invalid call to onDismiss

94baa23

import spy not all sinon lib

e0b8d4a

nihaux force-pushed the issue#5211 branch from c384313 to e0b8d4a Compare September 22, 2016 11:14

muibot added the PR: Needs Review label Sep 22, 2016

forgotten import

17db592

oliviertassinari added breaking change PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Sep 22, 2016

oliviertassinari merged commit ca963e4 into mui:master Sep 22, 2016

oliviertassinari changed the title ~~[TimePickerDialog] fix #5211 invalid call to onDismiss~~ [TimePickerDialog] Remove the call to onDismiss when already calling onAccept Sep 24, 2016

oliviertassinari changed the title ~~[TimePickerDialog] Remove the call to onDismiss when already calling onAccept~~ [TimePicker] Remove the call to onDismiss when already calling onAccept Sep 24, 2016

oliviertassinari mentioned this pull request May 22, 2017

DatePicker executing onDismiss even on OK click #6915

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TimePicker] Remove the call to onDismiss when already calling onAccept #5213

[TimePicker] Remove the call to onDismiss when already calling onAccept #5213

nihaux commented Sep 18, 2016 •

edited by oliviertassinari

Loading

oliviertassinari Sep 20, 2016

oliviertassinari commented Sep 22, 2016

[TimePicker] Remove the call to onDismiss when already calling onAccept #5213

[TimePicker] Remove the call to onDismiss when already calling onAccept #5213

Conversation

nihaux commented Sep 18, 2016 • edited by oliviertassinari Loading

oliviertassinari Sep 20, 2016

Choose a reason for hiding this comment

oliviertassinari commented Sep 22, 2016

nihaux commented Sep 18, 2016 •

edited by oliviertassinari

Loading