-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add a Q&A section around the next branch #5718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to nit-pick! As you know from our brief meeting in Paris, your English is far better than my French (!), so please accept this review as mere suggestions. Your original text is perfectly clear without these refinements. 👍
@@ -8,7 +8,7 @@ The roadmap is a living document, and it is likely that priorities will change, | |||
|
|||
The `next` release is going to be huge :sparkles: | |||
|
|||
Material-UI was started [2 years ago](https://github.com/callemall/material-ui/commit/28b768913b75752ecf9b6bb32766e27c241dbc46). | |||
Material-UI has started [2 years ago](https://github.com/callemall/material-ui/commit/28b768913b75752ecf9b6bb32766e27c241dbc46). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"was started" is grammatically correct.
- [[#2251](https://github.com/callemall/material-ui/issues/2251)] Full featured Table. | ||
## Q&A with the `next` branch | ||
|
||
The `next` branch has gained some maturity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'has become more mature'
## Q&A with the `next` branch | ||
|
||
The `next` branch has gained some maturity. | ||
We think that it's a good time to communicate more in this effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'more on this effort.'
The CSS (cascading style sheets) specification emerged in 1994. | ||
At that time, a bunch of others specifications were competing. | ||
That's the cascading part that made is succeed over his competitors. | ||
Allowing users to provide their own sheet, that will be later combined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'It was the cascading concept that made CSS succeed over its competitors, by allowing users to provide their own style-sheet, that will be later combined.'
Combined with what?
At that time, a bunch of others specifications were competing. | ||
That's the cascading part that made is succeed over his competitors. | ||
Allowing users to provide their own sheet, that will be later combined. | ||
That feature was removed 2 years ago from the most popular browser in the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'from the most popular browsers.'
|
||
1. We focus on migrating the components to the `next` branch. They may not be fully migrated. | ||
2. We merge the `next` branch into master. | ||
At that point, we gonna stop supporting the `v0.16.x` releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'we're going to'
5. We release our first pre-release. | ||
6. We ship :100:. | ||
|
||
### Have we ever considered using the best libraries for each functionality and provide only a wrapper for the UI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'each piece of functionality'
We have, it really depends on the problem we are trying to solve. | ||
For UI related things, providing a wrapper for the functionality is often the wrong approach. | ||
We think that it should be done the other way around. | ||
I.e. providing a low-level API that can be combined with third-party libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'the other way around, i.e. providing..."
For UI related things, providing a wrapper for the functionality is often the wrong approach. | ||
We think that it should be done the other way around. | ||
I.e. providing a low-level API that can be combined with third-party libraries. | ||
E.g: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'libraries, e.g.:'
- [react-swipeable-views](https://github.com/oliviertassinari/react-swipeable-views) | ||
- [react-dnd](https://github.com/gaearon/react-dnd) | ||
|
||
On the other, using a smart data library for the DatePicker / TimePicker would probably be much better as data management is tricky and not a core business. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'On the other hand,'
I don't know how we could be handling it without you. Thanks for correcting my english!
Thanks @lucasbento for asking those questions. That's a first iteration on the answers. There is room for improvement.
Thanks for the the clear explanation @oliviertassinari . |
The CSS (cascading style sheets) specification emerged in 1994. | ||
At that time, a bunch of others specifications were competing. | ||
It was the cascading concept that made CSS succeed over its competitors, by allowing users to provide their own style-sheet, that will be later combined with browsers and authors style-sheets. | ||
That feature was removed 2 years ago from the most popular browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the source for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please excuse the ignorance. If I wanted to use "next" today, how would I go about that? If I npm install from the github next branch, I get a "material-ui-build" folder in "node_modules", but the entry file in "package.json" doesn't export the components. Thanks. |
Excellent. Thank you. |
Thanks @lucasbento for asking those questions.
That's a first iteration on the answers.
There is room for improvement.