[TextField] value propType

[neilholcomb]

Allow Input component to except a number or a string as its value prop...instead of just string

• PR has tests / docs demo, and is linted.
• Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
• Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

[oliviertassinari]

What about value: PropTypes.any,?

[neilholcomb]

I am fine with any since it lets me pass in a number without errors....but does it make sense to allow arrays and objects and functions for an input? Or is it better that we just check something is sent in, and if your passing non scalar values that's on you? I'd be glad to change this to any just let me know your thoughts on allowing non scalar values

[oliviertassinari]

but does it make sense to allow arrays and objects and functions for an input?

Good point, I'm pretty convinced people we ask for it. I could ask the same question, does it makes sense to provide a number and not a string? People will try to provide boolean too.

[mbrookes]

Shouldn't that be:

import propTypes from '../utils/propTypes';
[...]
value: propTypes.stringOrNumber,

?

[oliviertassinari]

Oh, I didn't know we had stringOrNumber. I would rather remove that helper.
I don't think that this abstraction add much value.

[mbrookes]

It's only used in one other place, so easily done. I guess it will go away with next...