New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] make the node isRequired #6095

Merged

oliviertassinari merged 1 commit into next from button-children-required

Feb 10, 2017

Member

oliviertassinari commented Feb 9, 2017 •

edited

Loading

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

I'm not sure about the point of rendering a button without any children. That could help new users quicker understanding how to provide a label.

This one is for you @julien-meichelbeck.


          [Button] make the node isRequired

a767a5c

oliviertassinari added the next label

julien-meichelbeck commented Feb 9, 2017

You make it sound like I couldn't figure this out haha, thanks I guess !

oliviertassinari merged commit 812fee8 into next

oliviertassinari deleted the button-children-required branch

February 10, 2017 06:58

zannager added the component: button label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: button