-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs] Add a disabled property #6112
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// @flow weak | ||
/* eslint-disable react/no-multi-comp */ | ||
|
||
import React, { Component } from 'react'; | ||
import customPropTypes from 'material-ui/utils/customPropTypes'; | ||
import Paper from 'material-ui/Paper'; | ||
import Tabs from 'material-ui/Tabs'; | ||
import Tab from 'material-ui/Tabs/Tab'; | ||
|
||
export default class DisabledTabs extends Component { | ||
static contextTypes = { | ||
styleManager: customPropTypes.muiRequired, | ||
}; | ||
|
||
state = { | ||
index: 1, | ||
}; | ||
|
||
handleChange = (event, index) => { | ||
this.setState({ index }); | ||
}; | ||
|
||
render() { | ||
return ( | ||
<Paper> | ||
<Tabs index={this.state.index} onChange={this.handleChange}> | ||
<Tab label="Disabled" disabled /> | ||
<Tab label="Active" /> | ||
<Tab label="Disabled" disabled /> | ||
<Tab label="Active" /> | ||
</Tabs> | ||
</Paper> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,6 +61,10 @@ export default class Tab extends Component { | |
* The CSS class name of the root element. | ||
*/ | ||
className: PropTypes.string, | ||
/** | ||
* Disables the tab if set to true. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please could you follow this pattern for prop naming? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing this out |
||
*/ | ||
disabled: PropTypes.bool, | ||
/** | ||
* @ignore | ||
*/ | ||
|
@@ -105,6 +109,10 @@ export default class Tab extends Component { | |
]), | ||
}; | ||
|
||
static defaultProps = { | ||
disabled: false, | ||
}; | ||
|
||
static contextTypes = { | ||
styleManager: customPropTypes.muiRequired, | ||
}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we need a new example section for that. We could add a disable variation in one of the previous examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure which example to modify. There are four here
Can you point out which should be modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, that sounds good to me like this 👍