Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Added styles to GridList to display properly on IOS Safari Browser #6201

Closed
wants to merge 1 commit into from
Closed

[Docs] Added styles to GridList to display properly on IOS Safari Browser #6201

wants to merge 1 commit into from

Conversation

ballerabdude
Copy link

@ballerabdude ballerabdude commented Feb 21, 2017 •
edited
Loading

Added style to handle GridList on ios Safari

image

Closes #6194

@ballerabdude ballerabdude changed the title Added styles to GridList to display properly on IOS Safari Browser [GridList] Added styles to GridList to display properly on IOS Safari Browser Feb 21, 2017
@ballerabdude ballerabdude changed the title [GridList] Added styles to GridList to display properly on IOS Safari Browser [Docs] Added styles to GridList to display properly on IOS Safari Browser Feb 21, 2017
@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 21, 2017
oliviertassinari
oliviertassinari requested changes Feb 21, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I think that

  • the fix should be at the implementation level and not the docs one
  • actually fixing the issue:
    capture d ecran 2017-02-21 a 21 38 39

@oliviertassinari
Copy link
Member

I'm closing the PR. Thanks for your time. I have updated the issue. You have proved the validity of the issue 👍 . Hopefully, someone is going to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari requested changes

Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ballerabdude @oliviertassinari @muibot