When nested menu item Tapped call tap handler instead of click handler #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zulfatilyasov Will you please take a look at #581? It also solves the problem of calling the click handler twice, in addition to fixing another bug. |
|
@pomerantsev Do we still need to do this fix? |
|
@hai-cea Actually, I think this is part of the broader API inconsistency problem that I mentioned previously (item 3). Let me create a separate issue for that and submit a PR tomorrow. |
|
Fixed with #771 |
zannager
added
the
component: menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when nested menu item clicked, click handler is called twice. The reason is that when item is clicked both tap event and click event are fired but these events have the same hander
_onNestedItemClick. Tap event should have_onNestedItemTaphandler.