-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoComplete] Fix overriding TextField value and onChange prop #6642
[AutoComplete] Fix overriding TextField value and onChange prop #6642
Conversation
I'm not sure to understand the use case for that change. Don't we want user to override those values? |
E.g - Spreading props from redux-form fields.
If so - its a breaking change. |
Thanks for providing more detail. Alright, I guess we could make an exception for those two values as they are quite idiomatic in the React world and reduce the breaking change potential. |
{...other} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment for the why? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
Is there anything else?
@umidbekkarimov Thanks. |
edit: sorry no, that would be a breaking change too |
Fix for another regression caused by #6497.