Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui-icons] add making index.js #6676

Merged
merged 2 commits into from
Apr 24, 2017
Merged

Conversation

taichi
Copy link
Contributor

@taichi taichi commented Apr 23, 2017

material-ui-icons module suppports default member imports only.

this PR contains supporting member name imports.

for example,

  • now
import AddIcon from 'material-ui-icons/Add';
import AllOutIcon from 'material-ui-icons/AllOut';
  • this PR supports
import { Add, AllOut } from 'material-ui-icons';

@mbrookes
Copy link
Member

Well, we had https://github.com/callemall/material-ui/blob/master/scripts/icon-index-generator.js, but I left it out on next because adding one icon that way adds them all (without tree shaking).

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 23, 2017

without tree shaking

@mbrookes I think that we should let people taking advantage of the tree shaking.

@oliviertassinari
Copy link
Member

Actually, I think that we should update the documentation on that matter.

@mbrookes
Copy link
Member

@taichi Please could you update https://github.com/callemall/material-ui/blob/next/packages/material-ui-icons/src/README.md which is included in the NPM package?

@mbrookes mbrookes added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Apr 23, 2017
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm gonna tweak 2-3 things.

@oliviertassinari oliviertassinari added PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Apr 24, 2017
@oliviertassinari oliviertassinari merged commit b0bb523 into mui:next Apr 24, 2017
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants