-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui-icons] add making index.js #6676
Conversation
Well, we had https://github.com/callemall/material-ui/blob/master/scripts/icon-index-generator.js, but I left it out on |
@mbrookes I think that we should let people taking advantage of the tree shaking. |
Actually, I think that we should update the documentation on that matter. |
@taichi Please could you update https://github.com/callemall/material-ui/blob/next/packages/material-ui-icons/src/README.md which is included in the NPM package? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm gonna tweak 2-3 things.
material-ui-icons module suppports default member imports only.
this PR contains supporting member name imports.
for example,