Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transition] Add test coverage for shouldComponentUpdate() #6680

Merged

Conversation

agamrafaeli
Copy link
Contributor

No description provided.

@@ -322,4 +322,59 @@ describe('<Transition />', () => {
wrapper.setState({ in: false });
});
});

describe('TransitionshouldComponentUpdate', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldComponentUpdate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bahh...typos from coding at 2AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's time to sleep 😴 !

@oliviertassinari oliviertassinari merged commit f7d80fa into mui:next Apr 23, 2017
@agamrafaeli agamrafaeli deleted the transition-test-shouldComponentUpdate branch April 24, 2017 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants