[material-ui-icons] Modernize the package #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Apr 24, 2017
oliviertassinari
commented
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
muibot
added
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
mbrookes
reviewed
Apr 24, 2017
docs/src/pages/style/icons.md
Outdated
| @@ -12,7 +13,7 @@ Google has provided a set of [Material icons](https://material.io/icons/) that f | |||
|
|
|||
| Material-UI provides two components to render system icons: `Icon` for rendering font icons, and `SvgIcon` for rendering SVG paths. | |||
|
|
|||
| ### Font Icons | |||
| ## Font Icons | |||
There was a problem hiding this comment.
Font Icons is subsection of System icons:
"Material-UI provides two components to render system icons: Icon for rendering font icons, and SvgIcon for rendering SVG paths."
There was a problem hiding this comment.
I agree but visually speaking, I'm wondering if it's better to keep things flatten.
There was a problem hiding this comment.
Ok, I have put it back, as before 👍 .
docs/src/pages/style/icons.md
Outdated
| @@ -28,16 +29,20 @@ Optionally, you can set the icon color using one of the theme color properties: | |||
|
|
|||
| {{demo='pages/style/Icons.js'}} | |||
|
|
|||
| ### SVG Icons | |||
| ## SVG Icons | |||
docs/src/pages/style/icons.md
Outdated
| {{demo='pages/style/SvgPaths.js'}} | ||
| {{demo='pages/style/SvgIcons.js'}} | ||
|
|
||
| ## SVG Material icons |
There was a problem hiding this comment.
Arguably this is a subsection of SVG Icons...
|
Released a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.