[SvgIcon] Add aria-hidden #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
reviewed
May 9, 2017
src/SvgIcon/SvgIcon.js
Outdated
| @@ -39,6 +39,7 @@ export default function SvgIcon(props, context) { | |||
| <svg | |||
| className={className} | |||
| viewBox={viewBox} | |||
| aria-hidden="true" | |||
There was a problem hiding this comment.
Should we instead be adding the icon name as its title? What if this was in an Icon button? (Or is it up to the user to meaningfully label the button?)
There was a problem hiding this comment.
That's 20% of the use case following my previous 80%. I agree we miss a title property!
There was a problem hiding this comment.
Sorry, I missed the link in your description. I think this is best for now.
muibot
added
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in 80% of the situations, I'm adding it as default. See