[DatePicker] Now the date passed to DateTimeFormat is always in UTC #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAndrei
changed the title
oliviertassinari
approved these changes
Jun 5, 2017
There was a problem hiding this comment.
Two pieces of documentation I have used to check that PR DateTimeFormat and Date.UTC. That looks good to me. It would be awesome with a unit test on the new dateUTC helper.
oliviertassinari
added
component: date picker
|
@JustAndrei Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intl.DateTimeFormat is too smart: it takes into account historical changes in calendars. For instance, configure DatePicker to use Intl.DateTimeFormat (for internationalization) and try to select any date in March 2011. You'll see there are many bugs in calendar at that month, and the only reason is that Intl.DateTimeFormat is aware of that Europe started DST in March 2011.
This can easily be fixed if to make sure that
This way there are no surprises.