[TextField] Fix disabled input color in Safari #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,7 @@ const getStyles = (props, context, state) => { | |||
| color: props.disabled ? disabledTextColor : textColor, | |||
| cursor: 'inherit', | |||
| font: 'inherit', | |||
| WebkitTextFillColor: props.disabled ? disabledTextColor : textColor, | |||
There was a problem hiding this comment.
Would using currentColor work?
There was a problem hiding this comment.
I guess not as it's the inital value.
oliviertassinari
approved these changes
Jun 6, 2017
oliviertassinari
added
component: text field
|
Do we also have that issue on the next branch? |
|
Thanks |
oliviertassinari
added a commit
that referenced
this pull request
Jun 7, 2017
Port #7065 into the next branch, WebkitTextFillColor has proven not to be the right fix.
|
I have port that change into the next branch 964e112, the correct fix has proven to be otherwise. I'm assuming it's wrong in the master branch too. However, I don't have much interest looking into it, maybe you have. I have used WebkitOpacity instead. |
|
@oliviertassinari Interesting! I did some research yesterday but couldn't find much information on the root cause. As long as it works it's fine by me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an input field is rendered disabled in Safari the input color sometimes is ignored. Apparently this happens only with some colors (e.g.
#666leads to the bug, whereasbluedoesn't). Tested with Safari 10.1.1.See this Stack Overflow question for context.
Here's a JSFiddle demonstrating the issue and solution.