[TextField] Fix initial scroll #7260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The height of the TextField was not taking into account the size of the value when the TextField was first rendered. The code looks at the height of the hintText, or, if the value has changed, it looks at the height of the value. Made changes so that the value is passed into the function that is calculating the height, both when the component is mounted, or the component is resized. I have had to skip a unit test because jsdom does not support scrollHeight. The unit test code is within the test file, and could be "unskipped" later if jsdom can do layout, or another engine is used.
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
|
@brendanmh Thanks |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Jun 28, 2017
* call_em_all_-_master/master: [docs] Promote the v1.0.0-alpha (mui#7273) Issue 7175 (mui#7260) Fix regressions (mui#7262) [tests] correct values expected by autoprefixer (mui#7267) # Conflicts: # src/internal/FocusRipple.js * fixed step to have a default array of no children, as without it the tests were failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7175
The height of the TextField was not taking into account the size of the value when the TextField was first rendered.
The code looks at the height of the hintText, or, if the value has changed, it looks at the height of the value.
Made changes so that the value is passed into the function that is calculating the height, both when the component is mounted, or the component is resized.
I have had to skip a unit test because jsdom does not support scrollHeight. The unit test code is within the test file, and could be "unskipped" later if jsdom can do layout, or another engine is used.