Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Mark items on the supported components page as done #7492

Merged
merged 1 commit into from
Jul 20, 2017
Merged

[docs] Mark items on the supported components page as done #7492

merged 1 commit into from
Jul 20, 2017

Conversation

Airblader
Copy link
Contributor

@Airblader Airblader commented Jul 20, 2017 •
edited by oliviertassinari
Loading

fixes #7491

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari
Copy link
Member

Browserstack is slow today.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v1 labels Jul 20, 2017
@oliviertassinari oliviertassinari merged commit 2d40cc7 into mui:v1-alpha Jul 20, 2017
@Airblader
Copy link
Contributor Author

On a side note, #7477 doesn't build the docs website for me because it cannot resolve the dependency. I'll look into it.

@oliviertassinari
Copy link
Member

@Airblader Already fixed

@oliviertassinari
Copy link
Member

In #7461

@Airblader
Copy link
Contributor Author

Ah, alright. Thanks!

@oliviertassinari
Copy link
Member

@Airblader Just need to find the time to finish the PR now.

@Airblader
Copy link
Contributor Author

@oliviertassinari What about Toolbar? It does look like there is one already (AppBar uses it), but it's not documented separately.

@oliviertassinari
Copy link
Member

@Airblader We need to document it #4779.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Airblader @oliviertassinari