Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] Better support required field #7955

Merged
merged 1 commit into from
Aug 30, 2017
Merged

[Input] Better support required field #7955

merged 1 commit into from
Aug 30, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 29, 2017

Breaking change

Following Bootstrap, we are now forwarding the required property down to the input component. We used to only apply aria-required. This move makes us less opinionated and should help with native form handling.

If you want to avoid the default browser required property handling, you can add a noValidate property to the parent form.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 29, 2017

@rosskevin If you don't mind. I think that I will keep asking you a review on breaking changes PR 😁

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! v1 labels Aug 29, 2017
@oliviertassinari oliviertassinari merged commit 1a9b612 into mui:v1-beta Aug 30, 2017
@oliviertassinari oliviertassinari deleted the form-required branch August 30, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants