Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove defensive checks #8057

Merged
merged 1 commit into from
Sep 5, 2017
Merged

[docs] Remove defensive checks #8057

merged 1 commit into from
Sep 5, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Sep 5, 2017 •
edited
Loading

Follow-on to #8056

Good catch @oliviertassinari.

Tested generating api docs and all good.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@rosskevin rosskevin added docs Improvements or additions to the documentation v1 labels Sep 5, 2017
@rosskevin rosskevin merged commit 177a6f5 into mui:v1-beta Sep 5, 2017
@rosskevin rosskevin deleted the remove-docgen-defensive-checks branch September 5, 2017 18:45
@oliviertassinari oliviertassinari changed the title [docs:api] remove defensive checks [docs] Remove defensive checks Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosskevin @oliviertassinari