Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Fix BottomNavigations onChange type #8067

Merged
merged 1 commit into from
Sep 6, 2017
Merged

[typescript] Fix BottomNavigations onChange type #8067

merged 1 commit into from
Sep 6, 2017

Conversation

sebald
Copy link
Member

@sebald sebald commented Sep 6, 2017

…nge of BottomNavigationBottom.

Closes #8024

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari changed the title [typings] Make BottomNavigations onChange compatible with the onCha… [typescript] Make BottomNavigations onChange compatible with the onCha… Sep 6, 2017
@sebald sebald merged commit 015c780 into v1-beta Sep 6, 2017
@oliviertassinari oliviertassinari deleted the typings-onchange-bottomnavigation branch September 9, 2017 09:54
@oliviertassinari oliviertassinari changed the title [typescript] Make BottomNavigations onChange compatible with the onCha… [typescript] Fix BottomNavigations onChange types Sep 10, 2017
@oliviertassinari oliviertassinari changed the title [typescript] Fix BottomNavigations onChange types [typescript] Fix BottomNavigations onChange type Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebald @oliviertassinari