[typescript] Make StyledComponent only a type, not a class #8366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current TypeScript typings,
StyledComponent
is defined as a class which extendsReact.Component
, which doesn't reflect the reality of the underlying JS code. This leads one to believe that one can extendStyledComponent
as if it were a class, which it's not:The above will pass the type checker but lead to a runtime error, because no value
StyledComponent
is actually exported frommaterial-ui
.By extension, all the
material-ui
components are defined as being classes which extend this base class, butReact.Component
, notStyledComponent
which is not actually a class.This PR fixes the typing of
StyledComponent
by declaring it to just be a type, not a class, and changes all components to not extend that type, but simply to have that type.