[Collapse] Implement the ability to set the collapsed height through props #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: transitions
oliviertassinari
force-pushed
the
implement-collapsed-height-for-the-collapse-component
branch
2 times, most recently
from
c6777d6 to
ad53c57
Compare
|
@jackyho112 Thanks a lot for this proof of concept. I have taken the liberty to change the implementation a bit. Let me know if it looks correct. |
oliviertassinari
force-pushed
the
implement-collapsed-height-for-the-collapse-component
branch
from
ad53c57 to
82a68f2
Compare
|
@oliviertassinari Thanks for helping out! That looks much simpler and cleaner. It made me realize that a lot of code I did was most likely not worth it. Anyway, look forward to contributing more! 😄 |
|
@jackyho112 Don't worry, we need to try different things out to find the simplest solution to any problem. |
jackyho112
deleted the
implement-collapsed-height-for-the-collapse-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8235, so that the
Collapsecomponent takes acollapsedHeightprop to allow setting a custom height for the container to collapse to.For instance,
will do this:
This is my first PR, so hopefully, my implementation looks alright. Please let me know if there is any improvement you have in mind. 😄