[Example] Pin nextjs example to react 15 #8521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the beta of NextJS supports React 16 having both material-ui beta and nextjs beta in the example seems like a good recipe for the example to break regularly so better to pin to NextJS@latest and supported versions of React rather than NextJS@beta and React 16. |
oliviertassinari
approved these changes
Oct 3, 2017
oliviertassinari
added
PR: accepted
docs
|
@eyn Sounds good 👍 . |
|
@eyn Thanks, I can't wait for being able to upgrade the internal dependencies to react@16! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextJS latest does not support React 16 so pin to React 15.