-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TablePagination] Allow using it anywhere #8525
[TablePagination] Allow using it anywhere #8525
Conversation
I don't get it… The unit tests run fine on my machine. 😮 |
0652ba4
to
610669b
Compare
@leMaik I have some doubt about the validity of using the
@leMaik It should be good now :). |
@leMaik I have been making a mistake the first time. It should be better now. |
@oliviertassinari Uhm… No it isn't? If you set |
@oliviertassinari Well, there seem to be people who would like to use |
@leMaik You are right. It's time for me to sleep 😴 . |
1ee0e9d
to
034cb9c
Compare
034cb9c
to
1dfabb3
Compare
Any Samples Showing how to implement this without the table? |
@daiky00 What do you mean by a sample, where is this not working? |
This PR modifies the
TablePagination
so that it can be used everywhere. I also modified the TypeScript typings to include theTableCell
props and styles which might become handy for customizing the pagination (especially thecomponent
prop needs to be changed todiv
when not using the pagination inside a table).I'm not sure whether the component should be renamed to
Pagination
andTablePagination
should become a tiny wrapper around that wherecomponent
is set totd
? 🤔Breaking change
Closes #8520