Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Update description for displayEmpty propepty #8589

Merged
merged 1 commit into from
Oct 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/api/select.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ filename: /src/Select/Select.js
| autoWidth | boolean | false | If true, the width of the popover will automatically be set according to the items inside the menu, otherwise it will be at least the width of the select input. |
| <span style="color: #31a148">children *</span> | $ReadOnlyArray | | The option elements to populate the select with. Can be some `MenuItem` when `native` is false and `option` when `native` is true. |
| classes | Object | | Useful to extend the style applied to components. |
| displayEmpty | boolean | false | If `true`, the select selected item is display even if his value is empty. You can only use it when the `native` property is `false` (default). |
| displayEmpty | boolean | false | If `true`, the selected item is displayed even if its value is empty. You can only use it when the `native` property is `false` (default). |
| input | Element | &lt;Input /> | An `Input` element; does not have to be a material-ui specific `Input`. |
| multiple | boolean | false | If true, `value` must be an array and the menu will support multiple selections. You can only use it when the `native` property is `false` (default). |
| native | boolean | false | If `true`, the component will be using a native `select` element. |
Expand Down
2 changes: 1 addition & 1 deletion src/Select/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export type Props = {
*/
classes?: Object,
/**
* If `true`, the select selected item is display even if his value is empty.
* If `true`, the selected item is displayed even if its value is empty.
* You can only use it when the `native` property is `false` (default).
*/
displayEmpty?: boolean,
Expand Down
2 changes: 1 addition & 1 deletion src/Select/SelectInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export type Props = {
*/
disabled?: boolean,
/**
* If `true`, the select selected item is display even if his value is empty.
* If `true`, the selected item is displayed even if its value is empty.
* You can only use it when the `native` property is `false` (default).
*/
displayEmpty: boolean,
Expand Down
2 changes: 1 addition & 1 deletion src/Select/SelectInput.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('<SelectInput />', () => {
});

describe('prop: displayEmpty', () => {
it('should display the selected item even if his value is empty', () => {
it('should display the selected item even if its value is empty', () => {
const wrapper = shallow(
<SelectInput {...props} value="" displayEmpty>
<MenuItem value="">Ten</MenuItem>
Expand Down