[Select] Use onMouseDown as another opening event #9009
Conversation
src/Select/SelectInput.js
Outdated
| @@ -345,6 +345,7 @@ class SelectInput extends React.Component<ProvidedProps & Props, State> { | |||
| onKeyDown={this.handleKeyDown} | |||
| onBlur={this.handleBlur} | |||
| onClick={disabled || readOnly ? null : this.handleClick} | |||
There was a problem hiding this comment.
Do we still need this one?
There was a problem hiding this comment.
Originally I thought we needed it for handling the keyboard events, but just realized that this is already explicitly handled by the onKeyDown event. Also tested without the onClick on mobile and desktop, and seems to still work without it.
I fixed this in the second commit.
There was a problem hiding this comment.
Forgot to fix the unit tests though. This got me thinking that maybe we should keep the second handler for testing's sake. What do you think?
There was a problem hiding this comment.
We can update the tests too. The tests need to be as close as possible to what people use in the browser.
oliviertassinari
added
the
component: select
|
I'm having a look at this PR :) |
oliviertassinari
added
the
PR: needs revision
|
I'm sorry, this is definitely not a simple issue to fix. It's surfacing another issue with how the focus is handled. It's will require a rethink of how it's done. It's certainly not a one-line change. |
Fixes #8999.