Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Fix undefined blur event #9042

Merged
merged 1 commit into from
Nov 8, 2017
Merged

[TextField] Fix undefined blur event #9042

merged 1 commit into from
Nov 8, 2017

Conversation

nareshbhatia
Copy link
Contributor

@nareshbhatia nareshbhatia commented Nov 8, 2017

Added check for existence of event on FormControl.handleBlur(event). If event is undefined we don't call onBlur() of props.

Closes #9027

@nareshbhatia
Copy link
Contributor Author

I am seeing failed tests. Will look at these tomorrow.

@nareshbhatia
Copy link
Contributor Author

@oliviertassinari, my small change seems to have broken several unrelated tests. Is the build generally broken? Just trying to assess which tests I should be focusing on.

@oliviertassinari oliviertassinari changed the title Fixed issue #9027 [TextField] Fix undefined blur event Nov 8, 2017
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Nov 8, 2017
@oliviertassinari oliviertassinari merged commit 1a26a15 into mui:v1-beta Nov 8, 2017
@oliviertassinari
Copy link
Member

@nareshbhatia Thank you!

the-noob pushed a commit to the-noob/material-ui that referenced this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants