Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Go back to jss-vendor-prefixer@7 #9904

Merged

Conversation

oliviertassinari
Copy link
Member

Closes #9903
Closes #9900

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work core labels Jan 16, 2018
@oliviertassinari
Copy link
Member Author

We need to update the size-limit. The bundle size is down by 2 kB gzipped.

@oliviertassinari oliviertassinari merged commit 1e3fc12 into mui:v1-beta Jan 16, 2018
@oliviertassinari oliviertassinari deleted the jss-vendor-prefixer-7 branch January 16, 2018 12:55
@@ -71,13 +71,13 @@
"deepmerge": "^2.0.1",
"dom-helpers": "^3.2.1",
"hoist-non-react-statics": "^2.3.1",
"jss": "^9.5.0",
Copy link
Contributor

@kof kof Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you need this? I thought it is only a vendor prefixer thing

Copy link
Member Author

@oliviertassinari oliviertassinari Jan 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better keep the jss scope as wide as possible to avoid duplication in the bundle.

@rolandjitsu
Copy link
Contributor

Should we expect a release of this soon?

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 16, 2018

I will do a release before the end of the day. We have quite some fixes to release. I don't want to wait for the end of the week.

@rolandjitsu
Copy link
Contributor

rolandjitsu commented Jan 16, 2018

Sounds great, it'd be great to get this fix as soon as possible.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 16, 2018

@rolandjitsu You can rollback to v1.0.0-beta.27.

@rolandjitsu
Copy link
Contributor

@oliviertassinari I could, but I already made the changes for the theming breaking changes and I have no problem waiting for a day or two for this fix.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 16, 2018

@rolandjitsu We have made the theming change non-breaking in upcoming v1.0.0-beta.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants