-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Go back to jss-vendor-prefixer@7 #9904
[core] Go back to jss-vendor-prefixer@7 #9904
Conversation
We need to update the size-limit. The bundle size is down by 2 kB gzipped. |
f62c67f
to
f1a4623
Compare
@@ -71,13 +71,13 @@ | |||
"deepmerge": "^2.0.1", | |||
"dom-helpers": "^3.2.1", | |||
"hoist-non-react-statics": "^2.3.1", | |||
"jss": "^9.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you need this? I thought it is only a vendor prefixer thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better keep the jss scope as wide as possible to avoid duplication in the bundle.
Should we expect a release of this soon? |
I will do a release before the end of the day. We have quite some fixes to release. I don't want to wait for the end of the week. |
Sounds great, it'd be great to get this fix as soon as possible. |
@rolandjitsu You can rollback to v1.0.0-beta.27. |
@oliviertassinari I could, but I already made the changes for the theming breaking changes and I have no problem waiting for a day or two for this fix. |
@rolandjitsu We have made the theming change non-breaking in upcoming v1.0.0-beta.29. |
Closes #9903
Closes #9900