Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers][DateTimePicker] not showing 2 in the hour category, but shows 3 twice and the first isn't selectable #12403

Closed
kyle-rachau opened this issue Mar 10, 2024 · 11 comments · Fixed by #15849
Closed

[pickers][DateTimePicker] not showing 2 in the hour category, but shows 3 twice and the first isn't selectable #12403

kyle-rachau opened this issue Mar 10, 2024 · 11 comments · Fixed by #15849
Assignees
@flaviendelangle
Labels
bug 🐛 Something doesn't work component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! time-zone Issues about time zone management

Comments

@kyle-rachau
Copy link

kyle-rachau commented Mar 10, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Link to live example: (required)

https://mui.com/x/react-date-pickers/date-time-picker/

Steps:

  1. any date time picker, even the demos on the mui site are broke

Current behavior

The hour category shows 12-1-3-3-4-5

Expected behavior

The hour category shows 12-1-2-3-4-5

Context

Select time from date time picker
image

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: DateTimePicker hour
Order ID: 39752
@kyle-rachau kyle-rachau added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 10, 2024
@atrauzzi
Copy link

Screencast.from.2024-03-10.16-00-23.webm

I'm wondering if this has anything to do with daylight savings, which is today?

The video above is taken from https://mui.com/x/react-date-pickers/time-picker/

@kyle-rachau
Copy link
Author

Yea that was my guess too.

@michelengelen michelengelen added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! component: DateTimePicker The React component. labels Mar 11, 2024
@michelengelen michelengelen changed the title DateTimePicker not showing 2 in the hour category, but shows 3 twice and the first isn't selectable [pickers][DateTimePicker] not showing 2 in the hour category, but shows 3 twice and the first isn't selectable Mar 11, 2024
@michelengelen
Copy link
Member

Hey @atrauzzi could you tell me which timezone you are in? I cannot reproduce the issue, but I guess this could be due to a timezone issue (since different zones have different dates for the DST change)

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 11, 2024
@kyle-rachau
Copy link
Author

kyle-rachau commented Mar 11, 2024 •
edited
Loading

It seems to work this morning, but can't edit the previous day. It must have just been a DST change.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Mar 11, 2024
@michelengelen
Copy link
Member

Still ... I would like to investigate this, as this is clearly a bug, even if it only happens on a single day in the year. 🤔

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 11, 2024
@LukasTy LukasTy removed the status: waiting for author Issue with insufficient information label Mar 11, 2024
@LukasTy
Copy link
Member

LukasTy commented Mar 11, 2024 •
edited
Loading

This looks like a similar topic to #10783.
I'll look into it, whenever I get back to finalizing the PR for DigitalClock. 👌

@atrauzzi
Copy link

@michelengelen "America/Winnipeg" 👍

@flaviendelangle
Copy link
Member

@LukasTy do you want to mark that one as duplicate?

@LukasTy
Copy link
Member

LukasTy commented Mar 12, 2024

@LukasTy do you want to mark that one as duplicate?

Not sure that it can be treated as a duplicate. 🤔
The mentioned one concerns the DigitalClock component, whereas this one is about MultiSectionDigitalClock and TimeClock. 🤔

@flaviendelangle
Copy link
Member

If you think the two fixes will be handled independently then we can add this one to the board as well 👍

@LukasTy LukasTy mentioned this issue Apr 15, 2024
Closed
@LukasTy LukasTy added the time-zone Issues about time zone management label Oct 24, 2024
@arthurbalduini arthurbalduini mentioned this issue Oct 25, 2024
Closed
2 tasks
@flaviendelangle flaviendelangle mentioned this issue Dec 11, 2024
Merged
@flaviendelangle flaviendelangle self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@kyle-rachau How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! time-zone Issues about time zone management
Projects
None yet
Milestone
No milestone
5 participants
@atrauzzi @flaviendelangle @LukasTy @michelengelen @kyle-rachau