-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Implement Column groups #195
Comments
Hi! Is there an update on this feature? Any roadmap goals or something? @oliviertassinari |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This feature was less requested than others like #198, #212, #211 or #206. But if there is a need from the community, we should be able to plan it for Q2 👍 @xiaoyu-tamu, we are only updating the public roadmap one quarter at a time, because we don't want to give false hope on features that will be developed further away in time. |
Totally get it, there are other more urgent issues at hand. I don't think
this one should be very difficult to patch!!
Thanks a lot for your reply, best regards
…On Tue, Jan 25, 2022 at 9:18 AM Flavien DELANGLE ***@***.***> wrote:
This feature was a lot less requested than others like #198
<#198>, #212
<#212>, #211
<#211> or #206
<#206>, so we did not plan
to do it in Q1 2022.
But if there is a need from the community, we should be able to push it
for Q2 👍
—
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVQJBXQSUXYKK2RUHOISUULUX2IKTANCNFSM4QHJRGHQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Also would love to see this feature added. Good to see it's prioritized |
I hope to see this feature as soon |
I hope it will be added soon |
1 similar comment
I hope it will be added soon |
Is there any workaround for that now? Tried to customize Toolbar/Header, but horizontal scrolling doesn't work |
@oliviertassinari is there any room for this on your upcoming features? I noticed that it has many more upvotes than some of the items viewable in the future on the public MUI X roadmap. |
I can add it to the |
Sad to see this hasn't been moved into the Q2 section on the road map. Looking at replacing the current data grid we're using, and your data grid would certainly seems it would be the best fit overall, and already covers majority of the current needs, with the exception of the ability of having grouped header columns - and as such keeping me on the fence. Thought I certainly agree with the other features being prioritized, I do see this as being one of the vital core features a data grid should have, to avoid having to use excessively long column names when presenting certain types of data (E.g. shipper and receiver address information) to maintain a clear distinction to the user. Is there any chance still that we might see this one included during Q2? |
Hi @Gh0stscript, as @flaviendelangle said, we cannot guarantee the delivery of this feature in Q2. That's why we decided not to add it to Q2's public roadmap. But given its popularity within the community, we do plan to work on it soon (please keep upvoting your favorite issues; it helps us a lot!). We might be able to deliver it in Q2, and if not, it's happening at the beginning of Q3. |
We really need this at JP Morgan for our designs. I've been researching the features you have for the past few days and encouraged by the progress you've made in the recent months (really impressive!) but this is a deal breaker. I mean, how would we implement column grouping ourselves on top of what you have in a way that's not shoddy? So we are now evaluating AG Grid and Ant Design table that both support this feature and still don't lack in the areas MUI grid is good at or recently became good at. We are currently using Material UI grid v4.0 and plenty of other Material UI components and would really love to keep it that way, even if using MUI DataGridPro requires a license. |
@yay We bought this grid without knowing we would need column groups, so you are right, any implementation is shoddy but can be stable on top of virtualization/scrolling. It is less stable when resizing, and we don't use drag re-order so its not accounted for. Also not accessible. Looking forward to ripping out my shoddy code, as it makes updating that much harder since i override/extend so much (Sorry, this is my first gif upload, it looks weird) |
@joserodolfofreitas |
Do you need sorting on each child column or on the column group ? |
Each child column. |
In that case there should be no problem with the implementation we are preparing 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry for missing this comment. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey guys, |
The feature is under code review, and we'll likely launch it soon. |
Thanks for this feature. Is there a way we could style the column group with specific classes, right now headerClassName is not getting applied for columnGroupingModel. |
@sunilsr1986 Thanks for your feedback The current implementation allows I did not thought about the |
Thanks for the quick one and considering it. Ya right now I am managing with those two classes. Ya if the class names are added it would be nice to have each column group have it's own style / color. Please let us know if that's in. I can jump in to try that. |
@sunilsr1986 Feature has been added. You can see it in action in the customization demo |
@alexfauquette Thanks for the effort & info I checked on the latest version (5.15.1) but it's not there yet |
@keemor As long as the PR is not merged it's not available on the released version. Before releasing the feature, codesandbox generate a preview package from the PR, such that you can experiment with it before the release. This allows to share early feedbacks like the one about |
@sunilsr1986 I've been using the column |
Tested and it's working good. Thanks for that .. I have couple more involved. Could you please have a look with these as well ? Tested package https://pkg.csb.dev/mui/mui-x/commit/2c5ff802/@mui/x-data-grid |
@sunilsr1986 Yes, some features are missing from now and will be added one after the other. Here is the list of the one planned
Those features will be done in distinct commits such that we can have a detailed review of each of them, and not having them lost in the current PR. If you see other feature interaction we missed, feel free to ask for them. I will create the issues when PR is merged |
Hey, is this feature a commercial one? How to check that? |
@soumyaa1804 According to the documentation preview, it seems to be a free one. |
Grouping columns allows you to have multiple levels of columns in your header and the ability, if needed, to 'open and close' column groups to show and hide additional columns.
Benchamark
Column group collapse
The text was updated successfully, but these errors were encountered: